Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1133723005: Cherry-pick r234714: [MC] Write padding into fragments when -mc-relax-all flag is used (Closed)

Created:
5 years, 7 months ago by Mark Seaborn
Modified:
5 years, 7 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com, Petr Hosek, jvoung (off chromium)
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cherry-pick r234714: [MC] Write padding into fragments when -mc-relax-all flag is used Summary: When instruction bundling is enabled and the -mc-relax-all flag is set, we can write bundle padding directly into fragments and avoid creating large number of fragments significantly reducing LLVM MC memory usage. Test Plan: Regression test attached Reviewers: eliben Subscribers: jfb, mseaborn Differential Revision: http://reviews.llvm.org/D8072 BUG=https://code.google.com/p/nativeclient/issues/detail?id=4063 TEST=toolchain trybots R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/d0089f0b008e03cfd141f05c80e3b628c2df75c1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -37 lines) Patch
M include/llvm/MC/MCAsmLayout.h View 1 chunk +0 lines, -5 lines 0 comments Download
M include/llvm/MC/MCAssembler.h View 1 chunk +12 lines, -0 lines 0 comments Download
M include/llvm/MC/MCELFStreamer.h View 2 chunks +7 lines, -0 lines 0 comments Download
M include/llvm/MC/MCObjectStreamer.h View 2 chunks +6 lines, -4 lines 0 comments Download
M lib/MC/MCAssembler.cpp View 6 chunks +31 lines, -18 lines 0 comments Download
M lib/MC/MCELFStreamer.cpp View 1 6 chunks +88 lines, -2 lines 0 comments Download
M lib/MC/MCObjectStreamer.cpp View 5 chunks +10 lines, -4 lines 0 comments Download
M test/MC/X86/AlignedBundling/bundle-group-too-large-error.s View 1 chunk +1 line, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/different-sections.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/labeloffset.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/long-nop-pad.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/nesting.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/pad-align-to-bundle-end.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/pad-bundle-groups.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/relax-at-bundle-end.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/relax-in-bundle-group.s View 1 chunk +2 lines, -0 lines 0 comments Download
M test/MC/X86/AlignedBundling/single-inst-bundling.s View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Seaborn
5 years, 7 months ago (2015-05-12 22:34:03 UTC) #2
Derek Schuff
lgtm
5 years, 7 months ago (2015-05-12 23:01:57 UTC) #3
Mark Seaborn
5 years, 7 months ago (2015-05-13 01:49:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d0089f0b008e03cfd141f05c80e3b628c2df75c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698