PRESUBMIT.py - Issue 1133713009: Subject .mm files to the header sorting presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1133713009: Subject .mm files to the header sorting presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase - of course... it would be one of my patches I conflict with :| Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 860de560d5a4363c84a1d50642f08460bc459940..4548d4e461ab734c8fdeba9a94a3fb8b6a216b18 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -826,7 +826,7 @@ def _CheckIncludeOrder(input_api, output_api):

warnings = []

for f in input_api.AffectedFiles(file_filter=FileFilterIncludeOrder):

- if f.LocalPath().endswith(('.cc', '.h')):

+ if f.LocalPath().endswith(('.cc', '.h', '.mm')):

changed_linenums = set(line_num for line_num, _ in f.ChangedContents())

warnings.extend(_CheckIncludeOrderInFile(input_api, f, changed_linenums))

« no previous file with comments | « no previous file | base/files/file_util_mac.mm » ('j') | no next file with comments »