ui/base/cocoa/base_view.mm - Issue 1133713009: Subject .mm files to the header sorting presubmit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/cocoa/base_view.mm

Issue 1133713009: Subject .mm files to the header sorting presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase - of course... it would be one of my patches I conflict with :| Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/aura/window_tree_host_mac.mm ('k') | ui/gfx/canvas_unittest_mac.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/base/cocoa/base_view.h"	5 #include "ui/base/cocoa/base_view.h"

	6

6 #include "base/mac/mac_util.h"	7 #include "base/mac/mac_util.h"

7	8

8 NSString* kViewDidBecomeFirstResponder =	9 NSString* kViewDidBecomeFirstResponder =

9 @"Chromium.kViewDidBecomeFirstResponder";	10 @"Chromium.kViewDidBecomeFirstResponder";

10 NSString* kSelectionDirection = @"Chromium.kSelectionDirection";	11 NSString* kSelectionDirection = @"Chromium.kSelectionDirection";

11	12

12 @implementation BaseView	13 @implementation BaseView

13	14

14 - (instancetype)initWithFrame:(NSRect)frame {	15 - (instancetype)initWithFrame:(NSRect)frame {

15 if ((self = [super initWithFrame:frame])) {	16 if ((self = [super initWithFrame:frame])) {

(...skipping 160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
176 return new_rect;	177 return new_rect;

177 }	178 }

178	179

179 - (NSRect)flipRectToNSRect:(gfx::Rect)rect {	180 - (NSRect)flipRectToNSRect:(gfx::Rect)rect {

180 NSRect new_rect(NSRectFromCGRect(rect.ToCGRect()));	181 NSRect new_rect(NSRectFromCGRect(rect.ToCGRect()));

181 new_rect.origin.y = NSHeight([self bounds]) - NSMaxY(new_rect);	182 new_rect.origin.y = NSHeight([self bounds]) - NSMaxY(new_rect);

182 return new_rect;	183 return new_rect;

183 }	184 }

184	185

185 @end	186 @end

OLD	NEW