chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm - Issue 1133713009: Subject .mm files to the header sorting presubmit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Issue 1133713009: Subject .mm files to the header sorting presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase - of course... it would be one of my patches I conflict with :| Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.mm ('k') | chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h"	5 #import "chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h"

6	6

7 #include <Carbon/Carbon.h>	7 #include <Carbon/Carbon.h>

8	8

9 #include "base/mac/scoped_cftyperef.h"	9 #include "base/mac/scoped_cftyperef.h"

10 #import "base/mac/sdk_forward_declarations.h"	10 #import "base/mac/sdk_forward_declarations.h"

11 #import "chrome/browser/ui/cocoa/tabs/tab_controller.h"	11 #import "chrome/browser/ui/cocoa/tabs/tab_controller.h"

12 #import "chrome/browser/ui/cocoa/tabs/tab_controller_target.h"	12 #import "chrome/browser/ui/cocoa/tabs/tab_controller_target.h"

	13 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"

13 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"	14 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"

14 #import "chrome/browser/ui/cocoa/tabs/tab_view.h"	15 #import "chrome/browser/ui/cocoa/tabs/tab_view.h"

15 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"	16 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"

16 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"

17 #include "ui/gfx/mac/scoped_ns_disable_screen_updates.h"	17 #include "ui/gfx/mac/scoped_ns_disable_screen_updates.h"

18	18

19 const CGFloat kTearDistance = 36.0;	19 const CGFloat kTearDistance = 36.0;

20 const NSTimeInterval kTearDuration = 0.333;	20 const NSTimeInterval kTearDuration = 0.333;

21	21

22 // Returns whether \|screenPoint\| is inside the bounds of \|view\|.	22 // Returns whether \|screenPoint\| is inside the bounds of \|view\|.

23 static BOOL PointIsInsideView(NSPoint screenPoint, NSView* view) {	23 static BOOL PointIsInsideView(NSPoint screenPoint, NSView* view) {

24 if ([view window] == nil)	24 if ([view window] == nil)

25 return NO;	25 return NO;

26 NSPoint windowPoint = [[view window] convertScreenToBase:screenPoint];	26 NSPoint windowPoint = [[view window] convertScreenToBase:screenPoint];

(...skipping 473 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
500 [[targetController_ window] makeMainWindow];	500 [[targetController_ window] makeMainWindow];

501 } else {	501 } else {

502 [dragWindow_ setAlphaValue:0.5];	502 [dragWindow_ setAlphaValue:0.5];

503 [[draggedController_ overlayWindow] setHasShadow:NO];	503 [[draggedController_ overlayWindow] setHasShadow:NO];

504 [[draggedController_ window] makeMainWindow];	504 [[draggedController_ window] makeMainWindow];

505 }	505 }

506 chromeIsVisible_ = shouldBeVisible;	506 chromeIsVisible_ = shouldBeVisible;

507 }	507 }

508	508

509 @end	509 @end

OLD	NEW