Source/modules/serviceworkers/ServiceWorker.cpp - Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorker.cpp

Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorker.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorker.cpp b/Source/modules/serviceworkers/ServiceWorker.cpp

index ab07c75ce177c864c16a47190d810c221ad80797..c8ee444cc62e52d7f8e2f34492ff02de48d507f2 100644

--- a/Source/modules/serviceworkers/ServiceWorker.cpp

+++ b/Source/modules/serviceworkers/ServiceWorker.cpp

@@ -117,7 +117,7 @@ PassRefPtrWillBeRawPtr<ServiceWorker> ServiceWorker::from(ExecutionContext* exec

bool ServiceWorker::hasPendingActivity() const

{

- if (AbstractWorker::hasPendingActivity())

+ if (ActiveDOMObject::hasPendingActivity())

return true;

if (m_wasStopped)

return false;

« Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « Source/core/workers/DedicatedWorkerThread.cpp ('k') | no next file » | no next file with comments »