Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: Source/core/dom/ContextLifecycleNotifier.cpp

Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/core/workers/DedicatedWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContextLifecycleNotifier.cpp
diff --git a/Source/core/dom/ContextLifecycleNotifier.cpp b/Source/core/dom/ContextLifecycleNotifier.cpp
index 7ce7a1e25bbee4d0b8d054840842f8dc41271571..5c76f5bb18ed037fc0a08d58ebf37724e00ad3a7 100644
--- a/Source/core/dom/ContextLifecycleNotifier.cpp
+++ b/Source/core/dom/ContextLifecycleNotifier.cpp
@@ -107,6 +107,7 @@ unsigned ContextLifecycleNotifier::activeDOMObjectCount() const
bool ContextLifecycleNotifier::hasPendingActivity() const
{
+ // Any idea on how to handle this usage of ActiveDOMObject::hasPendingActivity?
haraken 2015/05/15 12:14:25 It seems that ContextLifecycleNotifier::hasPending
kinuko 2015/05/19 16:02:30 My old memory tells me that this code is (was?) us
for (ContextLifecycleObserver* observer : m_observers) {
if (observer->observerType() != ContextLifecycleObserver::ActiveDOMObjectType)
continue;
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/core/workers/DedicatedWorkerGlobalScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698