Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1133703002: Reduce GPU watchdog polling frequency (Closed)

Created:
5 years, 7 months ago by Andre
Modified:
5 years, 7 months ago
Reviewers:
jbauman, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@cpu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce GPU watchdog polling frequency Reduce GPU watchdog's polling interval from 2 seconds to 5 seconds. Also remove unnecessary CheckArmed() call from DidProcessTask(). Although CheckArmed() checks first whether it needs to post the task, WillProcessTask and DidProcessTask is called so quickly that armed() still returns true, so we ended up posting the task twice most of the time. BUG=483622 Committed: https://crrev.com/5be9f7266a13ec28a4852ec6f54fcad3e9d6a417 Cr-Commit-Position: refs/heads/master@{#329709}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/gpu/gpu_watchdog_thread.cc View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Andre
jbauman, PTAL.
5 years, 7 months ago (2015-05-08 20:46:28 UTC) #3
Andre
jbauman, ping?
5 years, 7 months ago (2015-05-13 16:59:38 UTC) #5
jbauman
lgtm
5 years, 7 months ago (2015-05-13 18:26:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133703002/20001
5 years, 7 months ago (2015-05-13 19:41:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-13 20:40:31 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 20:41:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5be9f7266a13ec28a4852ec6f54fcad3e9d6a417
Cr-Commit-Position: refs/heads/master@{#329709}

Powered by Google App Engine
This is Rietveld 408576698