Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 11337028: Merge 132922 - Remove ensureAuxiliaryContext (Closed)

Created:
8 years, 1 month ago by karen
Modified:
8 years, 1 month ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 132922 - Remove ensureAuxiliaryContext https://bugs.webkit.org/show_bug.cgi?id=99975 Patch by Dan Carney <dcarney@google.com>; on 2012-10-30 Reviewed by Adam Barth. Source/WebCore: Removed auxilliaryContext as use if it is problematic in IDB. No new tests. No change in functionality. * Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::setValueReady): * Modules/indexeddb/IDBCursor.h: (IDBCursor): * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::generateIndexKeysForValue): (WebCore::IDBObjectStore::put): (WebCore): * Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): * bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromScriptValueAndKeyPath): (WebCore::deserializeIDBValue): (WebCore::injectIDBKeyIntoScriptValue): * bindings/v8/IDBBindingUtilities.h: (WebCore): * bindings/v8/V8Binding.cpp: (WebCore::toV8Context): (WebCore): * bindings/v8/V8Binding.h: (WebCore): * bindings/v8/V8PerIsolateData.cpp: (WebCore): * bindings/v8/V8PerIsolateData.h: Source/WebKit/chromium: Updated tests to use correct v8 context. * tests/IDBBindingUtilitiesTest.cpp: (WebKit::checkKeyFromValueAndKeyPathInternal): (WebKit::checkKeyPathNullValue): (WebKit::injectKey): (WebKit::checkInjection): (WebKit::checkInjectionFails): (WebKit::checkKeyPathStringValue): (WebKit::checkKeyPathNumberValue): (WebKit::scriptExecutionContext): (WebKit): (WebKit::TEST): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -22 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBRequest.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp View 7 chunks +47 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/IDBBindingUtilities.cpp View 6 chunks +7 lines, -9 lines 0 comments Download
M Source/WebCore/bindings/v8/V8PerIsolateData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/bindings/v8/V8PerIsolateData.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebKit/chromium/WebKit.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp View 7 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 1 month ago (2012-10-30 19:04:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698