Chromium Code Reviews
Help | Chromium Project | Sign in
(327)

Issue 11337020: A Speculative Revert for 164872 - Enable force-compositing-mode on developer and continuous builds.… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Hironori Bono
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

A Speculative Revert for 164872 - Enable force-compositing-mode on developer and continuous builds. This should start running the
page-cyclers with FCM.


BUG=152355
Review URL: https://chromiumcodereview.appspot.com/11337014

TBR=vangelis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Lint Patch
M chrome/browser/chrome_gpu_util.cc View 1 chunk +0 lines, -6 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Hironori Bono
1 year, 5 months ago #1
Hironori Bono
Greetings, Sorry for reverting your change. I would like to try a speculative revert to ...
1 year, 5 months ago #2
Hironori Bono
Greetings, It seems failing tests are cycling green after reverting your change (*1). Is it ...
1 year, 5 months ago #3
vangelis
1 year, 5 months ago #4
Hi Hironori,
  Let me have a look at the failures.  The trybots were happy with the
change but it is possible that it made some tests flaky...

Thanks,
Vangelis



On Tue, Oct 30, 2012 at 4:29 AM, <hbono@chromium.org> wrote:

> Greetings,
>
> It seems failing tests are cycling green after reverting your change (*1).
> Is it
> possible to disable the compositing mode on browser_tests, e.g. adding a
> '--disable-force-compositing-**mode' option to the BrowserTestBase::SetUp
> function?
>
> (*1)
> http://build.chromium.org/p/**chromium.mac/builders/Mac10.6%**
>
20Tests%20%281%29/builds/31314<http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/31314>
>
>
> Regards,
>
> Hironori Bono
>
>
>
https://codereview.chromium.**org/11337020/<https://codereview.chromium.org/1...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6