Add errorprone into third_party

CLOSED: merged into https://codereview.chromium.org/1136573002/


Errorprone makes it easy to find problems quickly.
This review just puts adds it, but doesn't use it.
That part is in another review (see related review below).

No changes to the original source.
Added ChromiumErrorProneCompiler.java as a main entry point for Chromium.

Added GYP and GYN files with two targets (for standard errorprone and chromium errorprone).

Related Review:
https://codereview.chromium.org/1136573002

Added
open-source-third-party-reviews and security following the directions at http://www.chromium.org/developers/adding-3rd-party-libraries

BUG=485598

[raywilliams, 2015-05-07 18:13:28]

raywilliams@google.com changed reviewers:
+ cjhopman@chromium.org, cpu@chromium.org, jbudorick@chromium.org

[raywilliams, 2015-05-07 18:23:55]

raywilliams@google.com changed reviewers:
+ open-source-third-party-reviews@google.com, security@google.com
- cpu@chromium.org

[raywilliams, 2015-05-07 18:25:30]

raywilliams@google.com changed reviewers:
+ security@chromium.org
- security@google.com

[jbudorick, 2015-05-07 18:49:14]

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/erro...
File third_party/errorprone/errorprone.gyp (right):

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/erro...
third_party/errorprone/errorprone.gyp:29:
'../../build/android/setup.gyp:sun_tools_java',
These reviews aren't just related; they're interdependent because of the gyp/GN
changes.

Also, if errorprone is disabled, why does this need sun_tools_java? It
shouldn't.

Also, sun_tools_java concerns me; I'll have to look at exactly how errorprone
needs it and get back to you.

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/src/...
File
third_party/errorprone/src/org/chromium/errorprone/ChromiumErrorProneCompiler.java
(right):

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/src/...
third_party/errorprone/src/org/chromium/errorprone/ChromiumErrorProneCompiler.java:35:
private static int compile(String[] args) {
Why are we creating our own wrapper executable? Is there no errorprone binary we
can call directly?

[jbudorick, 2015-05-07 18:50:15]

oh, and use your chromium.org account for changes to chromium.

[cjhopman, 2015-05-07 19:00:37]

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
File third_party/errorprone/BUILD.gn (right):

https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
third_party/errorprone/BUILD.gn:19: "//build/android:sun_tools_java",
This doesn't exist. I'd either move the sun tools stuff into this change or move
this java_binary definition into the other. Probably the latter.

[raywilliams, 2015-05-07 19:10:24]

On 2015/05/07 19:00:37, cjhopman wrote:
>
https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
> File third_party/errorprone/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
> third_party/errorprone/BUILD.gn:19: "//build/android:sun_tools_java",
> This doesn't exist. I'd either move the sun tools stuff into this change or
move
> this java_binary definition into the other. Probably the latter.

You're right. I wanted to split the work into two parts, so third party people
only see the parts that they care about.

I'll probably move sun_tools_java into this review.

[chromium-reviews, 2015-05-07 19:20:12]

yeah, as third party person, i have no comments since this has no third
party files in it :)


On Thu, May 7, 2015 at 12:10 PM, <raywilliams@google.com> wrote:

> On 2015/05/07 19:00:37, cjhopman wrote:
>
>
>
https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
>
>> File third_party/errorprone/BUILD.gn (right):
>>
>
>
>
>
https://codereview.chromium.org/1133673002/diff/1/third_party/errorprone/BUIL...
>
>> third_party/errorprone/BUILD.gn:19: "//build/android:sun_tools_java",
>> This doesn't exist. I'd either move the sun tools stuff into this change
>> or
>>
> move
>
>> this java_binary definition into the other. Probably the latter.
>>
>
> You're right. I wanted to split the work into two parts, so third party
> people
> only see the parts that they care about.
>
> I'll probably move sun_tools_java into this review.
>
> https://codereview.chromium.org/1133673002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raywilliams, 2015-05-07 22:05:44]

I've merged this stuff into https://codereview.chromium.org/1136573002/

I'll keep this one open for a little bit for reference.

I thought we needed third party approval,
but if that's not the case then we might as well keep it all in one place :)

[jschuh, 2015-05-11 22:38:29]

jschuh@chromium.org changed reviewers:
- security@chromium.org

[jschuh, 2015-05-11 22:40:34]

Please start a thread with security@chromium.org explaining what this new
dependency is, how it will be used (e.g. test code), and whether the code or any
artifacts produced from it will be shyipped in Chrome.