PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

ppapi/cpp/file_ref.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_CPP_FILE_REF_H_
 #define PPAPI_CPP_FILE_REF_H_
 
 #include "ppapi/c/pp_file_info.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ppapi/c/ppb_file_ref.h"
@@ skipping 97 matching lines @@
   /// system as well as any parent directories. It is not valid to make a
   /// directory in the external file system.
   ///
   /// @param[in] cc A <code>CompletionCallback</code> to be called upon
   /// completion of MakeDirectoryIncludingAncestors().
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
   /// Succeeds if the directory already exists.
   int32_t MakeDirectoryIncludingAncestors(const CompletionCallback& cc);
 
+  /// MakeDirectoryExclusive() makes a new directory in the file system as well
+  /// as any parent directories. It is not valid to make a directory in the
+  /// external file system.
+  ///
+  /// @param[in] make_ancestors A <code>PP_Bool</code> set to
+  /// <code>PP_TRUE</code> to make ancestor directories or <code>PP_FALSE</code>
+  /// if ancestor directories are not needed.
+  /// @param[in] cc A <code>CompletionCallback</code> to be called upon
+  /// completion of MakeDirectoryIncludingAncestors().
+  ///
+  /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
+  /// Fails if the directory already exists or if ancestor directories do not
+  /// exist and <code>make_ancestors</code> was passed as <code>PP_FALSE</code>.
+  int32_t MakeDirectoryExclusive(PP_Bool make_ancestors,

[teravest, 2013/12/19 17:18:20]

It's sad that this looks different than
MakeDirectory/MakeDirectoryIncludingAncestors above.

What do you think of
MakeDirectoryExclusive/MakeDirectoryExclusiveIncludingAncestors?

It's a long name, but at least it would be consistent.

Otherwise, this should use "bool" instead of "PP_Bool".

[raymes, 2013/12/19 23:10:23]

It seems a bit weird that we made a whole new function here instead of just
adding a bool to MakeDirectory =\ Not sure the reasons for that.

My preference would be to just have MakeDirectory(bool make ancestors, bool
exclusive, const CompletionCallback& cc); The existing functions can be
deprecated and just call through that one. What do you guys think?

+                                 const CompletionCallback& cc);
+
   /// Touch() Updates time stamps for a file.  You must have write access to the
   /// file if it exists in the external filesystem.
   ///
   /// @param[in] last_access_time The last time the file was accessed.
   /// @param[in] last_modified_time The last time the file was modified.
   /// @param[in] cc A <code>CompletionCallback</code> to be called upon
   /// completion of Touch().
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
   int32_t Touch(PP_Time last_access_time,
@@ skipping 54 matching lines @@
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
   int32_t ReadDirectoryEntries(
       const CompletionCallbackWithOutput< std::vector<DirectoryEntry> >&
           callback);
 };
 
 }  // namespace pp
 
 #endif  // PPAPI_CPP_FILE_REF_H_