PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

ppapi/api/ppb_file_ref.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the API to create a file reference or "weak pointer" to a
  * file in a file system.
  */
 
 label Chrome {
   M14 = 1.0,
-  M28 = 1.1
+  M28 = 1.1,
+  M34 = 1.2
 };
 
 /**
  * The <code>PPB_FileRef</code> struct represents a "weak pointer" to a file in
  * a file system.  This struct contains a <code>PP_FileSystemType</code>
  * identifier and a file path string.
  */
 interface PPB_FileRef {
   /**
    * Create() creates a weak pointer to a file in the given file system. File
@@ skipping 85 matching lines @@
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    * Succeeds if the directory already exists. Fails if ancestor directories
    * do not exist and <code>make_ancestors</code> was passed as
    * <code>PP_FALSE</code>.
    */
   int32_t MakeDirectory([in] PP_Resource directory_ref,
                         [in] PP_Bool make_ancestors,
                         [in] PP_CompletionCallback callback);
 
   /**
+   * MakeDirectoryExclusive() makes a new directory in the file system as well
+   * as any parent directories if the <code>make_ancestors</code> argument is
+   * <code>PP_TRUE</code>.  It is not valid to make a directory in the external
+   * file system.
+   *
+   * @param[in] file_ref A <code>PP_Resource</code> corresponding to a file
+   * reference.
+   * @param[in] make_ancestors A <code>PP_Bool</code> set to
+   * <code>PP_TRUE</code> to make ancestor directories or <code>PP_FALSE</code>
+   * if ancestor directories are not needed.
+   *
+   * @return An int32_t containing an error code from <code>pp_errors.h</code>.
+   * Fails if the directory already exists or if ancestor directories do not
+   * exist and <code>make_ancestors</code> was passed as <code>PP_FALSE</code>.
+   */
+  [version=1.2]
+  int32_t MakeDirectoryExclusive([in] PP_Resource directory_ref,

[raymes, 2013/12/19 23:10:23]

Can we instead just add a PP_Bool to MakeDirectory() which specifies whether or
not an error should be thrown if the directory exists?

Also the comment on this function doesn't seem to explain it properly :p

[nhiroki, 2013/12/20 01:54:20]

Oh, I see. I assumed we have to add new function with new name when we want to
change an existing API in order to prevent plugins from getting broken, but now
I understand the way from other idl files.

Anyway, I'll fix this according to your comment.

+                                 [in] PP_Bool make_ancestors,
+                                 [in] PP_CompletionCallback callback);
+
+  /**
    * Touch() Updates time stamps for a file.  You must have write access to the
    * file if it exists in the external filesystem.
    *
    * @param[in] file_ref A <code>PP_Resource</code> corresponding to a file
    * reference.
    * @param[in] last_access_time The last time the file was accessed.
    * @param[in] last_modified_time The last time the file was modified.
    * @param[in] callback A <code>PP_CompletionCallback</code> to be called upon
    * completion of Touch().
    *
@@ skipping 68 matching lines @@
    * completion.
    *
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    */
   [version=1.1]
   int32_t ReadDirectoryEntries([in] PP_Resource file_ref,
                                [in] PP_ArrayOutput output,
                                [in] PP_CompletionCallback callback);
 };