Add unit tests for stroke rects and drawVertices

Add unit tests for stroke rects and drawVertices

TBR=bsalomon@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/e590266294c4c92e4e4c2f06f267ac5751d07562

[joshualitt, 2015-05-07 19:18:11]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-05-07 19:18:11]

ptal

[joshualitt, 2015-05-08 18:31:14]

On 2015/05/07 19:18:11, joshualitt wrote:
> ptal

just bumping this guy, he might have gotten lost in the flurry.  No rush.

[robertphillips, 2015-05-08 18:32:17]

I guess I never pressed publish on this one :(

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1921: geometry.fRect = GrTest::TestRect(random);
A big one? 10?

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1928: switch(type) {
add // fall throughs 
?

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:2009: 
I, personally, would do "for (int i = 1; ..." but feel free to ignore.

[robertphillips, 2015-05-08 18:40:13]

lgtm + nits & a question

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1927: static int seed_vertices(GrPrimitiveType type) {
space between 'h' and '(' ?

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1965: 
Actually use min & max ?

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:2002: int i = 1;
Maybe kMinVertExtent, kMaxVertExtent instead of -100, 100 ?

https://codereview.chromium.org/1133613004/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:2020: SkRect bounds;
Don't we want to assert that the bound is finite ?

[joshualitt, 2015-05-08 19:04:13]

Brian, rubber stamp please.

[joshualitt, 2015-05-11 14:53:26]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-11 14:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1133613004/#ps60001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-11 14:53:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133613004/60001

[commit-bot: I haz the power, 2015-05-11 14:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 14:56:53]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[joshualitt, 2015-05-11 15:12:19]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-11 15:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1133613004/#ps140001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-11 15:12:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133613004/140001

[commit-bot: I haz the power, 2015-05-11 15:18:42]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/e590266294c4c92e4e4c2f06f267ac5751d07562