Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1133613002: Revert of mini_installer: Change to use _countof rather than base's arraysize macro. (Closed)

Created:
5 years, 7 months ago by grt (UTC plus 2)
Modified:
5 years, 7 months ago
Reviewers:
tfarina
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mini_installer: Change to use _countof rather than base's arraysize macro. (patchset #3 id:40001 of https://codereview.chromium.org/1126163003/) Reason for revert: Broke signing build. Original issue's description: > Replace mini_installer's use of arraysize macro with range-based for loops > and/or _countof. > > * Remove the duplication in the decompress.h > > https://msdn.microsoft.com/en-us/library/ms175773.aspx > > This issue arised when doing https://codereview.chromium.org/1115993004/. > > BUG=None > TEST=trybots > R=grt@chromium.org > > Committed: https://crrev.com/016d71e2e048f0578e2c53c3f741755173ef8cb2 > Cr-Commit-Position: refs/heads/master@{#328623} TBR=tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/4febac2867bb9dd87b033bdd1b059888c6faa9eb Cr-Commit-Position: refs/heads/master@{#328753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M chrome/installer/mini_installer/configuration_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/installer/mini_installer/decompress.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/decompress.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/installer/mini_installer/mini_string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/mini_string_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of mini_installer: Change to use _countof rather than base's arraysize macro.
5 years, 7 months ago (2015-05-07 13:28:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133613002/1
5 years, 7 months ago (2015-05-07 13:28:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 13:30:12 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 13:31:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4febac2867bb9dd87b033bdd1b059888c6faa9eb
Cr-Commit-Position: refs/heads/master@{#328753}

Powered by Google App Engine
This is Rietveld 408576698