Add create_density_splits option to java_apk.gypi / android_apk (gn)

Add create_density_splits option to java_apk.gypi / android_apk (gn)

BUG=488324
Committed: https://crrev.com/ac94e41f40bfc5252dc23dd72549d985ca221168
Cr-Commit-Position: refs/heads/master@{#331177}

[agrieve, 2015-05-15 18:18:17]

agrieve@chromium.org changed reviewers:
+ cjhopman@chromium.org, nednguyen@google.com

[nednguyen, 2015-05-15 18:54:17]

lgtm

[nednguyen, 2015-05-15 18:55:37]

On 2015/05/15 18:54:17, nednguyen (slow review) wrote:
> lgtm

I truly apologize for the annoying step of updating TELEMETRY_DEPS. We will
working on fixing this so that not all changes to build/android blows up the
telemetry dependencies check +__+

[agrieve, 2015-05-17 02:49:08]

Forgot about gyp_managed_install when I uploaded this. Please don't review yet.

[agrieve, 2015-05-19 14:47:33]

On 2015/05/17 02:49:08, agrieve wrote:
> Forgot about gyp_managed_install when I uploaded this. Please don't review
yet.

This is now ready to go.

[cjhopman, 2015-05-20 01:51:52]

https://codereview.chromium.org/1133603004/diff/40001/build/android/finalize_...
File build/android/finalize_splits_action.gypi (right):

https://codereview.chromium.org/1133603004/diff/40001/build/android/finalize_...
build/android/finalize_splits_action.gypi:52:
'<(base_output_path)-density-xdpi.apk',
should these be xhdpi/xxhdpi?

https://codereview.chromium.org/1133603004/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1133603004/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:672:
finalize_apk("${target_name}__finalize_${_density}_split") {
nit: I'd extract this target name to a variable.

https://codereview.chromium.org/1133603004/diff/40001/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/1133603004/diff/40001/build/java_apk.gypi#new...
build/java_apk.gypi:667: '<(final_apk_path_no_extension)-density-xdpi.apk',
should these be xhdpi/xxhdpi?

[agrieve, 2015-05-20 14:49:36]

https://codereview.chromium.org/1133603004/diff/40001/build/android/finalize_...
File build/android/finalize_splits_action.gypi (right):

https://codereview.chromium.org/1133603004/diff/40001/build/android/finalize_...
build/android/finalize_splits_action.gypi:52:
'<(base_output_path)-density-xdpi.apk',
On 2015/05/20 01:51:51, cjhopman wrote:
> should these be xhdpi/xxhdpi?

Nice catch!

https://codereview.chromium.org/1133603004/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1133603004/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:672:
finalize_apk("${target_name}__finalize_${_density}_split") {
On 2015/05/20 01:51:51, cjhopman wrote:
> nit: I'd extract this target name to a variable.

Done.

https://codereview.chromium.org/1133603004/diff/40001/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/1133603004/diff/40001/build/java_apk.gypi#new...
build/java_apk.gypi:667: '<(final_apk_path_no_extension)-density-xdpi.apk',
On 2015/05/20 01:51:51, cjhopman wrote:
> should these be xhdpi/xxhdpi?

Done.

[nednguyen, 2015-05-21 21:51:36]

https://codereview.chromium.org/1133603004/diff/80001/tools/telemetry/telemet...
File tools/telemetry/telemetry/TELEMETRY_DEPS (right):

https://codereview.chromium.org/1133603004/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/TELEMETRY_DEPS:72:
"build/android/finalize_splits_action.gypi",
FYI, https://codereview.chromium.org/1156543003/ is landed, so you shouldn't
need to touch TELEMETRY_DEPS file.

[agrieve, 2015-05-22 01:46:23]

https://codereview.chromium.org/1133603004/diff/80001/tools/telemetry/telemet...
File tools/telemetry/telemetry/TELEMETRY_DEPS (right):

https://codereview.chromium.org/1133603004/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/TELEMETRY_DEPS:72:
"build/android/finalize_splits_action.gypi",
On 2015/05/21 21:51:36, nednguyen wrote:
> FYI, https://codereview.chromium.org/1156543003/ is landed, so you shouldn't
> need to touch TELEMETRY_DEPS file.

Great! I'll revert this file.

[agrieve, 2015-05-22 01:46:42]

agrieve@chromium.org changed reviewers:
- nednguyen@google.com

[cjhopman, 2015-05-22 18:07:56]

lgtm

[agrieve, 2015-05-22 18:33:28]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-05-22 18:33:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, cjhopman@chromium.org
Link to the patchset: https://codereview.chromium.org/1133603004/#ps100001
(title: "removed TELEMETRY_DEPS change")

[commit-bot: I haz the power, 2015-05-22 18:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133603004/100001

[commit-bot: I haz the power, 2015-05-22 20:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 20:31:52]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[agrieve, 2015-05-22 20:37:37]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-05-22 20:39:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133603004/100001

[commit-bot: I haz the power, 2015-05-22 21:32:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-22 21:33:11]

Patchset 6 (id:??) landed as
https://crrev.com/ac94e41f40bfc5252dc23dd72549d985ca221168
Cr-Commit-Position: refs/heads/master@{#331177}