Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 11336016: Revert 128379 - IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible (Closed)

Created:
8 years, 1 month ago by alecflett
Modified:
8 years, 1 month ago
Reviewers:
alecflett
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Revert 128379 - IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible https://bugs.webkit.org/show_bug.cgi?id=94023 Patch by Alec Flett <alecflett@chromium.org>; on 2012-09-12 Reviewed by Kentaro Hara. Transition the put/add/update methods to accept direct ScriptValue objects rather than SerializedScriptValues, to eliminate lots of redundant deserialization/serialization steps while storing values. Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for followup get/openCursor work, following this. No new tests, this is a performance refactor of core IDB functionality. Most existing tests cover correctness. Tests that might fail include: storage/indexeddb/objectstore-basics.html storage/indexeddb/keypath-basics.html storage/indexeddb/index-basics.html * Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::update): * Modules/indexeddb/IDBCursor.h: (IDBCursor): * Modules/indexeddb/IDBCursor.idl: * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::generateIndexKeysForValue): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore): * Modules/indexeddb/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (IDBObjectStore): * Modules/indexeddb/IDBObjectStore.idl: * bindings/v8/IDBBindingUtilities.cpp: (WebCore): (WebCore::createIDBKeyFromScriptValueAndKeyPath): (WebCore::deserializeIDBValue): (WebCore::canInjectIDBKeyIntoScriptValue): * bindings/v8/IDBBindingUtilities.h: (WebCore): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -132 lines) Patch
MM Source/WebCore/Modules/indexeddb/IDBCursor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBCursor.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
MM Source/WebCore/Modules/indexeddb/IDBCursor.idl View 1 chunk +1 line, -1 line 0 comments Download
MM Source/WebCore/Modules/indexeddb/IDBObjectStore.h View 3 chunks +5 lines, -5 lines 0 comments Download
MM Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp View 8 chunks +14 lines, -20 lines 0 comments Download
MM Source/WebCore/Modules/indexeddb/IDBObjectStore.idl View 1 chunk +2 lines, -2 lines 0 comments Download
MM Source/WebCore/bindings/v8/IDBBindingUtilities.h View 2 chunks +0 lines, -7 lines 0 comments Download
MM Source/WebCore/bindings/v8/IDBBindingUtilities.cpp View 6 chunks +15 lines, -94 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alecflett
8 years, 1 month ago (2012-10-29 17:46:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698