Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/utils.dart

Issue 1133593004: fixes #131, use before define from variables to classes (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix static fields Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/dependency_graph.dart ('K') | « lib/src/js/printer.dart ('k') | test/codegen/expect/constructors.js » ('j') | test/codegen/expect/misc.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/utils.dart
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
index 12a5081f1c85e761625f4464b5c1d45e26560852..d9ccdac94ac96584535e041f3ee49e7f7db88319 100644
--- a/lib/src/utils.dart
+++ b/lib/src/utils.dart
@@ -387,8 +387,10 @@ Object getConstantField(
return (f == null || f.type != expectedType) ? null : f.value;
}
-InterfaceType fillDynamicTypeArgs(InterfaceType t, TypeProvider types) =>
- t.substitute4(new List.filled(t.typeArguments.length, types.dynamicType));
+ParameterizedType fillDynamicTypeArgs(ParameterizedType t, TypeProvider types) {
Jennifer Messerly 2015/05/12 16:23:46 also works for function types now
+ var dyn = new List.filled(t.typeArguments.length, types.dynamicType);
+ return t.substitute2(dyn, t.typeArguments);
+}
/// Similar to [SimpleIdentifier] inGetterContext, inSetterContext, and
/// inDeclarationContext, this method returns true if [node] is used in an
« lib/src/dependency_graph.dart ('K') | « lib/src/js/printer.dart ('k') | test/codegen/expect/constructors.js » ('j') | test/codegen/expect/misc.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698