Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1133583002: Fix signatures of isValidKey arguments to CanonicalizedMap constructors. (Closed)

Created:
5 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 7 months ago
Reviewers:
wibling
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/collection.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix signatures of isValidKey arguments to CanonicalizedMap constructors. R=wibling@google.com Committed: https://github.com/dart-lang/collection/commit/4d71c7ea1489c6d1b2dc07ebf2ac2f9babd7a002

Patch Set 1 #

Patch Set 2 : Update version number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/canonicalized_map.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-07 11:12:59 UTC) #2
wibling
lgtm
5 years, 7 months ago (2015-05-07 11:13:23 UTC) #3
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-07 11:13:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4d71c7ea1489c6d1b2dc07ebf2ac2f9babd7a002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698