Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: media/renderers/video_renderer_impl.cc

Issue 1133563010: Add a GpuMemoryBuffer pool that creates hardware backed VideoFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a mem leak. Remove TODO in VideoRendererImpl. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/video_renderer_impl.cc
diff --git a/media/renderers/video_renderer_impl.cc b/media/renderers/video_renderer_impl.cc
index 722438681254ddc4fa26a895a6f64e0540c15e68..f47ee18037db540b38629fc6876bb7090bbbaa8b 100644
--- a/media/renderers/video_renderer_impl.cc
+++ b/media/renderers/video_renderer_impl.cc
@@ -21,6 +21,8 @@
#include "media/base/media_switches.h"
#include "media/base/pipeline.h"
#include "media/base/video_frame.h"
+#include "media/renderers/gpu_video_accelerator_factories.h"
+#include "media/video/gpu_memory_buffer_video_frame_pool.h"
namespace media {
@@ -43,6 +45,7 @@ VideoRendererImpl::VideoRendererImpl(
VideoRendererSink* sink,
ScopedVector<VideoDecoder> decoders,
bool drop_frames,
+ scoped_refptr<GpuVideoAcceleratorFactories> gpu_factories,
DaleCurtis 2015/05/14 00:58:57 const& ?
Daniele Castagna 2015/05/14 17:30:25 Done.
const scoped_refptr<MediaLog>& media_log)
: task_runner_(task_runner),
use_new_video_renderering_path_(ShouldUseVideoRenderingPath()),
@@ -50,6 +53,8 @@ VideoRendererImpl::VideoRendererImpl(
sink_started_(false),
video_frame_stream_(
new VideoFrameStream(task_runner, decoders.Pass(), media_log)),
+ gpu_memory_buffer_pool_(
+ new GpuMemoryBufferVideoFramePool(task_runner, gpu_factories)),
DaleCurtis 2015/05/14 00:58:57 Do you want this owned by each VideoRendererImpl (
Daniele Castagna 2015/05/14 17:30:25 We were thinking about one per video tag right now
DaleCurtis 2015/05/14 18:52:13 sgtm, but you guys are the experts :)
low_delay_(false),
received_end_of_stream_(false),
rendered_end_of_stream_(false),

Powered by Google App Engine
This is Rietveld 408576698