media/renderers/default_renderer_factory.cc - Issue 1133563010: Add a GpuMemoryBuffer pool that creates hardware backed VideoFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/default_renderer_factory.cc

Issue 1133563010: Add a GpuMemoryBuffer pool that creates hardware backed VideoFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a mem leak. Remove TODO in VideoRendererImpl. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/mojo/services/mojo_renderer_service.cc ('k') | media/renderers/gpu_video_accelerator_factories.h » ('j') | media/renderers/video_renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/renderers/default_renderer_factory.cc

diff --git a/media/renderers/default_renderer_factory.cc b/media/renderers/default_renderer_factory.cc

index 0ec129a47dd8bef26dc90ec628e40acc77e9da65..a2a91d5b16491407ab11c48507c4d7c834f9c9ca 100644

--- a/media/renderers/default_renderer_factory.cc

+++ b/media/renderers/default_renderer_factory.cc

@@ -76,9 +76,9 @@ scoped_ptr<Renderer> DefaultRendererFactory::CreateRenderer(

video_decoders.push_back(new FFmpegVideoDecoder(media_task_runner));

#endif

- scoped_ptr<VideoRenderer> video_renderer(

- new VideoRendererImpl(media_task_runner, video_renderer_sink,

- video_decoders.Pass(), true, media_log_));

+ scoped_ptr<VideoRenderer> video_renderer(new VideoRendererImpl(

+ media_task_runner, video_renderer_sink, video_decoders.Pass(), true,

+ gpu_factories_, media_log_));

// Create renderer.

return scoped_ptr<Renderer>(new RendererImpl(