Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: content/renderer/media/renderer_gpu_video_accelerator_factories.h

Issue 1133563010: Add a GpuMemoryBuffer pool that creates hardware backed VideoFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/renderer_gpu_video_accelerator_factories.h
diff --git a/content/renderer/media/renderer_gpu_video_accelerator_factories.h b/content/renderer/media/renderer_gpu_video_accelerator_factories.h
index 2d1299a569433e5e8dc3b6fd2b5447903121c761..3b388c91a44f00c43b5fe05f658942c1da25692e 100644
--- a/content/renderer/media/renderer_gpu_video_accelerator_factories.h
+++ b/content/renderer/media/renderer_gpu_video_accelerator_factories.h
@@ -20,6 +20,10 @@ namespace base {
class WaitableEvent;
}
+namespace gpu {
+class GpuMemoryBufferManager;
+}
+
namespace content {
class ContextProviderCommandBuffer;
class GLHelper;
@@ -58,6 +62,15 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories
uint32 texture_target) override;
void DeleteTexture(uint32 texture_id) override;
void WaitSyncPoint(uint32 sync_point) override;
+
+ scoped_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(
+ const gfx::Size& size,
+ gfx::GpuMemoryBuffer::Format format,
+ gfx::GpuMemoryBuffer::Usage usage) override;
+
+ // Return or create a GLES2Interface. This method must be called from the
+ // thread associated with the 'task_runner' passed to the constructor.
reveman 2015/05/12 03:20:24 nit: think this is implied from the class descript
Daniele Castagna 2015/05/12 21:21:29 Removed the comment.
+ gpu::gles2::GLES2Interface* GetGLES2Interface() override;
scoped_ptr<base::SharedMemory> CreateSharedMemory(size_t size) override;
scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() override;
@@ -87,6 +100,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories
scoped_refptr<GpuChannelHost> gpu_channel_host_;
scoped_refptr<ContextProviderCommandBuffer> context_provider_;
scoped_ptr<GLHelper> gl_helper_;
+ gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager_;
reveman 2015/05/12 03:20:24 nit: const pointer
Daniele Castagna 2015/05/12 21:21:29 Do you mean gpu::GpuMemoryBufferManager* const? Do
// For sending requests to allocate shared memory in the Browser process.
scoped_refptr<ThreadSafeSender> thread_safe_sender_;

Powered by Google App Engine
This is Rietveld 408576698