Adding WebThread and new BlinkPlatformImpl for utility thread.

Adding WebThread and new BlinkPlatformImpl for utility thread.

For ensuring that the blink is always initialized with WebThread, the
call sites of blink must implement WebThread to expose the task runner.
UtilityThread is the only case where blink is run without exposing the
platform thread. This CL adds new WebThread implementation for
UtilityThread. After this change blink will always initialized with
platform thread and task runner exposed.

BUG=486782
Committed: https://crrev.com/90e34895f20edf97693c14ac0ec6faf64dbdcd91
Cr-Commit-Position: refs/heads/master@{#329442}

[ssid, 2015-05-11 16:46:17]

ssid@chromium.org changed reviewers:
+ picksi@chromium.org, skyostil@chromium.org

[Sami, 2015-05-11 17:08:02]

Non-owner lgtm with some nits.

https://codereview.chromium.org/1133563007/diff/40001/content/utility/utility...
File content/utility/utility_blink_platform_impl.h (right):

https://codereview.chromium.org/1133563007/diff/40001/content/utility/utility...
content/utility/utility_blink_platform_impl.h:16: virtual
~UtilityBlinkPlatformImpl();
nit: ~UtilityBlinkPlatformImpl() override;

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
File content/utility/webthread_impl_for_utility_thread.h (right):

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:15: explicit
WebThreadImplForUtilityThread();
No need for explicit since there are no parameters.

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:16: virtual
~WebThreadImplForUtilityThread();
~WebThreadImplForUtilityThread() override;

[ssid, 2015-05-11 17:20:59]

ssid@chromium.org changed reviewers:
+ mpcomplete@chromium.org, sievers@chromium.org

[ssid, 2015-05-11 17:21:00]

+sievers Please review the changes.

https://codereview.chromium.org/1133563007/diff/40001/content/utility/utility...
File content/utility/utility_blink_platform_impl.h (right):

https://codereview.chromium.org/1133563007/diff/40001/content/utility/utility...
content/utility/utility_blink_platform_impl.h:16: virtual
~UtilityBlinkPlatformImpl();
On 2015/05/11 17:08:02, Sami wrote:
> nit: ~UtilityBlinkPlatformImpl() override;

Done.

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
File content/utility/webthread_impl_for_utility_thread.h (right):

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:15: explicit
WebThreadImplForUtilityThread();
On 2015/05/11 17:08:02, Sami wrote:
> No need for explicit since there are no parameters.

Done.

https://codereview.chromium.org/1133563007/diff/40001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:16: virtual
~WebThreadImplForUtilityThread();
On 2015/05/11 17:08:02, Sami wrote:
> ~WebThreadImplForUtilityThread() override;

Done.

[no sievers, 2015-05-11 18:27:14]

Can you update the bug with what the actual bug/problem is, and the cl with what
this changes functionally in the behavior?

I think you mean to say in the description not that there is not platform thread
in the utility process (there is), but that it's not exposed through the
Platform interface?

https://codereview.chromium.org/1133563007/diff/60001/content/content_utility...
File content/content_utility.gypi (right):

https://codereview.chromium.org/1133563007/diff/60001/content/content_utility...
content/content_utility.gypi:18: 'utility/utility_blink_platform_impl.cc',
nit: put before line 17

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
File content/utility/webthread_impl_for_utility_thread.h (right):

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:8: #include
"base/containers/scoped_ptr_hash_map.h"
you mean base/memory/ref_counted.h?

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:28: blink::PlatformThreadId
thread_id_;
DISALLOW_COPY_AND_ASSIGN

[ssid, 2015-05-12 09:42:18]

Thanks, Fixed comments and updated the description. PTAL.

https://codereview.chromium.org/1133563007/diff/60001/content/content_utility...
File content/content_utility.gypi (right):

https://codereview.chromium.org/1133563007/diff/60001/content/content_utility...
content/content_utility.gypi:18: 'utility/utility_blink_platform_impl.cc',
On 2015/05/11 18:27:14, sievers wrote:
> nit: put before line 17

Done.

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
File content/utility/webthread_impl_for_utility_thread.h (right):

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:8: #include
"base/containers/scoped_ptr_hash_map.h"
On 2015/05/11 18:27:14, sievers wrote:
> you mean base/memory/ref_counted.h?

sorry, changed.

https://codereview.chromium.org/1133563007/diff/60001/content/utility/webthre...
content/utility/webthread_impl_for_utility_thread.h:28: blink::PlatformThreadId
thread_id_;
On 2015/05/11 18:27:14, sievers wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[no sievers, 2015-05-12 17:54:33]

lgtm

[ssid, 2015-05-12 18:05:13]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-05-12 18:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1133563007/#ps80001
(title: "Fixing style.")

[commit-bot: I haz the power, 2015-05-12 18:05:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133563007/80001

[commit-bot: I haz the power, 2015-05-12 18:10:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-12 18:11:12]

Patchset 5 (id:??) landed as
https://crrev.com/90e34895f20edf97693c14ac0ec6faf64dbdcd91
Cr-Commit-Position: refs/heads/master@{#329442}