Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1133563004: Revert of Oilpan: Enable lazy sweeping on non-oilpan builds (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Enable lazy sweeping on non-oilpan builds (patchset #2 id:20001 of https://codereview.chromium.org/1055193004/) Reason for revert: The use of lazy sweeping appears to be behind this ASan regression, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/18437/layout-test-results/http/tests/serviceworker/fetch-canvas-tainting-crash-log.txt i.e., it risks lifecycle notification touching already finalized & freed objects. Original issue's description: > Oilpan: Enable lazy sweeping on non-oilpan builds > > Currently lazy sweeping is enabled only on oilpan builds. Since the lazy sweeping has been stable on the oilpan builds for >3 months, I think it's now safe to enable it on non-oilpan builds as well. > > BUG=480837 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194808 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195022 TBR=oilpan-reviews@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Created Revert of Oilpan: Enable lazy sweeping on non-oilpan builds
5 years, 7 months ago (2015-05-07 18:07:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133563004/1
5 years, 7 months ago (2015-05-07 18:08:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195067
5 years, 7 months ago (2015-05-07 18:08:42 UTC) #3
sof
https://groups.google.com/a/chromium.org/forum/#!topic/oilpan-reviews/u3dax9mf9Go has more context.
5 years, 7 months ago (2015-05-07 18:09:12 UTC) #4
haraken
5 years, 7 months ago (2015-05-07 23:42:44 UTC) #5
Message was sent while issue was closed.
On 2015/05/07 18:09:12, sof wrote:
>
https://groups.google.com/a/chromium.org/forum/#!topic/oilpan-reviews/u3dax9m...
> has more context.

LGTM, thanks for the investigation!

Powered by Google App Engine
This is Rietveld 408576698