Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1133553002: Remove unused dependency. (Closed)

Created:
5 years, 7 months ago by qsr
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove unused dependency. R=jamesr@chromium.org BUG=https://github.com/domokit/mojo/issues/80 Committed: https://chromium.googlesource.com/external/mojo/+/72ca2c676c98cedbd36fdd10dcb197ce61a69459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/gl/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
James -> It doesn't seem we are using this dependency at all, and compiling it ...
5 years, 7 months ago (2015-05-07 08:38:04 UTC) #1
jamesr
You are correct. I wonder why this was here if we don't need it. lgtm
5 years, 7 months ago (2015-05-07 15:17:51 UTC) #2
qsr
On 2015/05/07 15:17:51, jamesr wrote: > You are correct. I wonder why this was here ...
5 years, 7 months ago (2015-05-07 15:23:27 UTC) #3
qsr
5 years, 7 months ago (2015-05-07 15:24:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72ca2c676c98cedbd36fdd10dcb197ce61a69459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698