Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1133543005: Use core_services for network_service on Android (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: Also bundle network_service on android. This creates an android_hooks.cc file, which we could currently share, but probably won't want to long term, as every time we add something to core_services, we'll have to merge their implementation in. BUG=477435 Committed: https://crrev.com/355e3f1944627652131a7dc60bf1a92fd4c979ad Cr-Commit-Position: refs/heads/master@{#329506}

Patch Set 1 #

Patch Set 2 : Fix android build? #

Patch Set 3 : Change ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -10 lines) Patch
M mandoline/app/core_services_initialization.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 2 chunks +45 lines, -9 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + mandoline/services/core_services/android_hooks.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
5 years, 7 months ago (2015-05-12 21:45:21 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-12 21:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133543005/40001
5 years, 7 months ago (2015-05-12 21:56:14 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 22:18:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:19:53 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/355e3f1944627652131a7dc60bf1a92fd4c979ad
Cr-Commit-Position: refs/heads/master@{#329506}

Powered by Google App Engine
This is Rietveld 408576698