Omnibox - Log Addition Crash Data for Rare HQP Crash

chrome/browser/autocomplete/history_quick_provider.cc

Index: chrome/browser/autocomplete/history_quick_provider.cc
diff --git a/chrome/browser/autocomplete/history_quick_provider.cc b/chrome/browser/autocomplete/history_quick_provider.cc
index 68cd805af91c950a9f5f13a6dfd9cf22509c1c02..7a0a6588163fc6e3b4868466722f420c62b24bb7 100644
--- a/chrome/browser/autocomplete/history_quick_provider.cc
+++ b/chrome/browser/autocomplete/history_quick_provider.cc
@@ -8,6 +8,7 @@
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
+#include "base/debug/crash_logging.h"
 #include "base/i18n/break_iterator.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ -258,6 +259,12 @@ AutocompleteMatch HistoryQuickProvider::QuickMatchToACMatch(
 
   // Set |inline_autocompletion| and |allowed_to_be_default_match| if possible.
   if (history_match.can_inline) {
+    base::debug::ScopedCrashKey crash_info(
+        "bug_464926_info",
+        info.url().spec() + " " +
+        base::UTF16ToUTF8(autocomplete_input_.text()) + " " +
+        base::SizeTToString(history_match.url_matches.size()) + " " +
+        base::SizeTToString(offsets.size()));;
     DCHECK(!new_matches.empty());

[Peter Kasting, 2015/05/11 23:34:42]

Can you upgrade this DCHECK to CHECK to find instances of this in the wild (and
add any other CHECKs that would help track this down too)?

[Mark P, 2015/05/11 23:45:15]

There is no need; it'll crash anyway on the line below it.

[Peter Kasting, 2015/05/11 23:47:13]

I'm mostly worried about it not crashing until slightly later (the way sometimes
null objects will let you do a bunch with them before barfing).  It seems like
it'd be maximally clear if this was a CHECK.

[Mark P, 2015/05/11 23:49:59]

Done.

     size_t inline_autocomplete_offset = new_matches[0].offset +
         new_matches[0].length;