Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1133523005: mac: Suppress partial availability warnings in theme helper. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Suppress partial availability warnings in theme helper. Moved the definition of a 10.7+ NSString constant into mac/sdk_forward_declarations.h, and ensured that the NSString is explicitly defined regardless of the OSX SDK version being compiled against. BUG=471823 Committed: https://crrev.com/7e72bc9f6d57f34bc0a3697b3b2c261bf0fbea3d Cr-Commit-Position: refs/heads/master@{#329459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/mac/sdk_forward_declarations.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/theme_helper_mac.mm View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
thakis: Looking for an OWNER review of base/mac/sdk_forward_declarations.* avi: Looking for an OWNER review of ...
5 years, 7 months ago (2015-05-12 01:07:31 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-12 02:21:01 UTC) #3
Nico
lgtm
5 years, 7 months ago (2015-05-12 03:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133523005/1
5 years, 7 months ago (2015-05-12 18:43:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 19:38:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:39:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e72bc9f6d57f34bc0a3697b3b2c261bf0fbea3d
Cr-Commit-Position: refs/heads/master@{#329459}

Powered by Google App Engine
This is Rietveld 408576698