Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Side by Side Diff: Source/platform/scroll/ProgrammaticScrollAnimator.cpp

Issue 1133513002: Animations: Port ProgrammaticScrollAnimator to use compositor timelines (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@linkhigh
Patch Set: Mark subframe-interrupted-scroll as flaky Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "platform/scroll/ProgrammaticScrollAnimator.h" 6 #include "platform/scroll/ProgrammaticScrollAnimator.h"
7 7
8 #include "platform/RuntimeEnabledFeatures.h"
8 #include "platform/geometry/IntPoint.h" 9 #include "platform/geometry/IntPoint.h"
9 #include "platform/graphics/GraphicsLayer.h" 10 #include "platform/graphics/GraphicsLayer.h"
10 #include "platform/scroll/ScrollableArea.h" 11 #include "platform/scroll/ScrollableArea.h"
11 #include "public/platform/Platform.h" 12 #include "public/platform/Platform.h"
12 #include "public/platform/WebCompositorAnimation.h" 13 #include "public/platform/WebCompositorAnimation.h"
14 #include "public/platform/WebCompositorAnimationPlayer.h"
15 #include "public/platform/WebCompositorAnimationTimeline.h"
13 #include "public/platform/WebCompositorSupport.h" 16 #include "public/platform/WebCompositorSupport.h"
14 #include "public/platform/WebScrollOffsetAnimationCurve.h" 17 #include "public/platform/WebScrollOffsetAnimationCurve.h"
15 18
16 namespace blink { 19 namespace blink {
17 20
18 PassOwnPtr<ProgrammaticScrollAnimator> ProgrammaticScrollAnimator::create(Scroll ableArea* scrollableArea) 21 PassOwnPtr<ProgrammaticScrollAnimator> ProgrammaticScrollAnimator::create(Scroll ableArea* scrollableArea)
19 { 22 {
20 return adoptPtr(new ProgrammaticScrollAnimator(scrollableArea)); 23 return adoptPtr(new ProgrammaticScrollAnimator(scrollableArea));
21 } 24 }
22 25
23 ProgrammaticScrollAnimator::ProgrammaticScrollAnimator(ScrollableArea* scrollabl eArea) 26 ProgrammaticScrollAnimator::ProgrammaticScrollAnimator(ScrollableArea* scrollabl eArea)
24 : m_scrollableArea(scrollableArea) 27 : m_compositorAnimationAttachedToLayerId(0)
28 , m_scrollableArea(scrollableArea)
25 , m_startTime(0.0) 29 , m_startTime(0.0)
26 , m_runState(RunState::Idle) 30 , m_runState(RunState::Idle)
27 , m_compositorAnimationId(0) 31 , m_compositorAnimationId(0)
28 , m_compositorAnimationGroupId(0) 32 , m_compositorAnimationGroupId(0)
29 { 33 {
34 if (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {
35 ASSERT(Platform::current()->compositorSupport());
36 m_compositorPlayer = adoptPtr(Platform::current()->compositorSupport()-> createAnimationPlayer());
37 ASSERT(m_compositorPlayer);
38 m_compositorPlayer->setAnimationDelegate(this);
39 }
30 } 40 }
31 41
32 ProgrammaticScrollAnimator::~ProgrammaticScrollAnimator() 42 ProgrammaticScrollAnimator::~ProgrammaticScrollAnimator()
33 { 43 {
44 if (m_compositorPlayer) {
45 m_compositorPlayer->setAnimationDelegate(nullptr);
46 m_compositorPlayer.clear();
47 }
34 } 48 }
35 49
36 void ProgrammaticScrollAnimator::resetAnimationState() 50 void ProgrammaticScrollAnimator::resetAnimationState()
37 { 51 {
38 m_animationCurve.clear(); 52 m_animationCurve.clear();
39 m_startTime = 0.0; 53 m_startTime = 0.0;
40 m_runState = RunState::Idle; 54 m_runState = RunState::Idle;
41 m_compositorAnimationId = 0; 55 m_compositorAnimationId = 0;
42 m_compositorAnimationGroupId = 0; 56 m_compositorAnimationGroupId = 0;
43 } 57 }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 } 143 }
130 144
131 void ProgrammaticScrollAnimator::updateCompositorAnimations() 145 void ProgrammaticScrollAnimator::updateCompositorAnimations()
132 { 146 {
133 if (m_compositorAnimationId && m_runState != RunState::RunningOnCompositor) { 147 if (m_compositorAnimationId && m_runState != RunState::RunningOnCompositor) {
134 // If the current run state is WaitingToSendToCompositor but we have a 148 // If the current run state is WaitingToSendToCompositor but we have a
135 // non-zero compositor animation id, there's a currently running 149 // non-zero compositor animation id, there's a currently running
136 // compositor animation that needs to be removed here before the new 150 // compositor animation that needs to be removed here before the new
137 // animation is added below. 151 // animation is added below.
138 ASSERT(m_runState == RunState::WaitingToCancelOnCompositor || m_runState == RunState::WaitingToSendToCompositor); 152 ASSERT(m_runState == RunState::WaitingToCancelOnCompositor || m_runState == RunState::WaitingToSendToCompositor);
139 if (GraphicsLayer* layer = m_scrollableArea->layerForScrolling()) 153
140 layer->removeAnimation(m_compositorAnimationId); 154 if (m_compositorPlayer) {
155 if (m_compositorPlayer->isLayerAttached())
156 m_compositorPlayer->removeAnimation(m_compositorAnimationId);
157 } else {
158 if (GraphicsLayer* layer = m_scrollableArea->layerForScrolling())
159 layer->removeAnimation(m_compositorAnimationId);
160 }
161
141 m_compositorAnimationId = 0; 162 m_compositorAnimationId = 0;
142 m_compositorAnimationGroupId = 0; 163 m_compositorAnimationGroupId = 0;
143 if (m_runState == RunState::WaitingToCancelOnCompositor) { 164 if (m_runState == RunState::WaitingToCancelOnCompositor) {
144 resetAnimationState(); 165 resetAnimationState();
145 return; 166 return;
146 } 167 }
147 } 168 }
148 169
149 if (m_runState == RunState::WaitingToSendToCompositor) { 170 if (m_runState == RunState::WaitingToSendToCompositor) {
150 bool sentToCompositor = false; 171 bool sentToCompositor = false;
151 172
152 if (GraphicsLayer* layer = m_scrollableArea->layerForScrolling()) { 173 if (GraphicsLayer* layer = m_scrollableArea->layerForScrolling()) {
153 if (!layer->platformLayer()->shouldScrollOnMainThread()) { 174 if (!layer->platformLayer()->shouldScrollOnMainThread()) {
154 OwnPtr<WebCompositorAnimation> animation = adoptPtr(Platform::cu rrent()->compositorSupport()->createAnimation(*m_animationCurve, WebCompositorAn imation::TargetPropertyScrollOffset)); 175 OwnPtr<WebCompositorAnimation> animation = adoptPtr(Platform::cu rrent()->compositorSupport()->createAnimation(*m_animationCurve, WebCompositorAn imation::TargetPropertyScrollOffset));
155 176
156 int animationId = animation->id(); 177 int animationId = animation->id();
157 int animationGroupId = animation->group(); 178 int animationGroupId = animation->group();
158 if (m_scrollableArea->layerForScrolling()->addAnimation(animatio n.release())) { 179
180 bool animationAdded = false;
181 if (m_compositorPlayer) {
182 if (m_compositorPlayer->isLayerAttached()) {
183 m_compositorPlayer->addAnimation(animation.leakPtr());
184 animationAdded = true;
185 }
186 } else {
187 animationAdded = m_scrollableArea->layerForScrolling()->addA nimation(animation.release());
188 }
189
190 if (animationAdded) {
159 sentToCompositor = true; 191 sentToCompositor = true;
160 m_runState = RunState::RunningOnCompositor; 192 m_runState = RunState::RunningOnCompositor;
161 m_compositorAnimationId = animationId; 193 m_compositorAnimationId = animationId;
162 m_compositorAnimationGroupId = animationGroupId; 194 m_compositorAnimationGroupId = animationGroupId;
163 } 195 }
164 } 196 }
165 } 197 }
166 198
167 if (!sentToCompositor) { 199 if (!sentToCompositor) {
168 m_runState = RunState::RunningOnMainThread; 200 m_runState = RunState::RunningOnMainThread;
169 if (!m_scrollableArea->scheduleAnimation()) { 201 if (!m_scrollableArea->scheduleAnimation()) {
170 notifyPositionChanged(IntPoint(m_targetOffset.x(), m_targetOffse t.y())); 202 notifyPositionChanged(IntPoint(m_targetOffset.x(), m_targetOffse t.y()));
171 resetAnimationState(); 203 resetAnimationState();
172 } 204 }
173 } 205 }
174 } 206 }
175 } 207 }
176 208
177 void ProgrammaticScrollAnimator::layerForCompositedScrollingDidChange() 209 void ProgrammaticScrollAnimator::reattachCompositorPlayerIfNeeded(WebCompositorA nimationTimeline* timeline)
178 { 210 {
211 int compositorAnimationAttachedToLayerId = 0;
212 if (m_scrollableArea->layerForScrolling())
213 compositorAnimationAttachedToLayerId = m_scrollableArea->layerForScrolli ng()->platformLayer()->id();
214
215 if (compositorAnimationAttachedToLayerId != m_compositorAnimationAttachedToL ayerId) {
216 if (m_compositorPlayer && timeline) {
217 // Detach from old layer (if any).
218 if (m_compositorAnimationAttachedToLayerId) {
219 ASSERT(m_compositorPlayer->isLayerAttached());
220 m_compositorPlayer->detachLayer();
221 timeline->playerDestroyed(*this);
222 }
223 // Attach to new layer (if any).
224 if (compositorAnimationAttachedToLayerId) {
225 ASSERT(m_scrollableArea->layerForScrolling());
226 timeline->playerAttached(*this);
227 m_compositorPlayer->attachLayer(m_scrollableArea->layerForScroll ing()->platformLayer());
228 }
229 m_compositorAnimationAttachedToLayerId = compositorAnimationAttached ToLayerId;
230 }
231 }
232 }
233
234 void ProgrammaticScrollAnimator::layerForCompositedScrollingDidChange(WebComposi torAnimationTimeline* timeline)
235 {
236 reattachCompositorPlayerIfNeeded(timeline);
237
179 // If the composited scrolling layer is lost during a composited animation, 238 // If the composited scrolling layer is lost during a composited animation,
180 // continue the animation on the main thread. 239 // continue the animation on the main thread.
181 if (m_runState == RunState::RunningOnCompositor && !m_scrollableArea->layerF orScrolling()) { 240 if (m_runState == RunState::RunningOnCompositor && !m_scrollableArea->layerF orScrolling()) {
182 m_runState = RunState::RunningOnMainThread; 241 m_runState = RunState::RunningOnMainThread;
183 m_compositorAnimationId = 0; 242 m_compositorAnimationId = 0;
184 m_compositorAnimationGroupId = 0; 243 m_compositorAnimationGroupId = 0;
185 m_animationCurve->setInitialValue(FloatPoint(m_scrollableArea->scrollPos ition())); 244 m_animationCurve->setInitialValue(FloatPoint(m_scrollableArea->scrollPos ition()));
186 m_scrollableArea->registerForAnimation(); 245 m_scrollableArea->registerForAnimation();
187 if (!m_scrollableArea->scheduleAnimation()) { 246 if (!m_scrollableArea->scheduleAnimation()) {
188 resetAnimationState(); 247 resetAnimationState();
(...skipping 16 matching lines...) Expand all
205 ASSERT_NOT_REACHED(); 264 ASSERT_NOT_REACHED();
206 break; 265 break;
207 case RunState::WaitingToSendToCompositor: 266 case RunState::WaitingToSendToCompositor:
208 break; 267 break;
209 case RunState::RunningOnCompositor: 268 case RunState::RunningOnCompositor:
210 case RunState::WaitingToCancelOnCompositor: 269 case RunState::WaitingToCancelOnCompositor:
211 resetAnimationState(); 270 resetAnimationState();
212 } 271 }
213 } 272 }
214 273
274 void ProgrammaticScrollAnimator::notifyAnimationStarted(double monotonicTime, in t group)
275 {
276 }
277
278 void ProgrammaticScrollAnimator::notifyAnimationFinished(double monotonicTime, i nt group)
279 {
280 notifyCompositorAnimationFinished(group);
281 }
282
283 WebCompositorAnimationPlayer* ProgrammaticScrollAnimator::compositorPlayer() con st
284 {
285 return m_compositorPlayer.get();
286 }
287
215 } // namespace blink 288 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/scroll/ProgrammaticScrollAnimator.h ('k') | Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698