Factor out core of Array.forEach and .every, for use in TypedArrays

src/harmony-typedarray.js

Index: src/harmony-typedarray.js
diff --git a/src/harmony-typedarray.js b/src/harmony-typedarray.js
index 793e855ae72d3a2df2a92f021045813fb4d9834c..51d732d5f042df670e31a6d96b737cf0fad7e3f8 100644
--- a/src/harmony-typedarray.js
+++ b/src/harmony-typedarray.js
@@ -30,67 +30,24 @@ TYPED_ARRAYS(DECLARE_GLOBALS)
 // -------------------------------------------------------------------
 
 // ES6 draft 05-05-15, section 22.2.3.7
-function TypedArrayEvery(f /* thisArg */) {  // length == 1
-  if (!%IsTypedArray(this)) {
-    throw MakeTypeError('not_typed_array', []);
-  }
-  if (!IS_SPEC_FUNCTION(f)) throw MakeTypeError(kCalledNonCallable, f);
+function TypedArrayEvery(f, receiver /* thisArg */) {  // length == 1

[adamk, 2015/05/11 22:39:24]

You can remove the "/* thisArg */" and "// length == 1" comments here, since you
now explicitly set the length below.

+  if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
 
   var length = %_TypedArrayGetLength(this);
-  var receiver;
-
-  if (%_ArgumentsLength() > 1) {
-    receiver = %_Arguments(1);
-  }
 
-  var needs_wrapper = false;
-  if (IS_NULL(receiver)) {
-    if (%IsSloppyModeFunction(mapfn)) receiver = UNDEFINED;
-  } else if (!IS_UNDEFINED(receiver)) {
-    needs_wrapper = SHOULD_CREATE_WRAPPER(f, receiver);
-  }
-
-  var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
-  for (var i = 0; i < length; i++) {
-    var element = this[i];
-    // Prepare break slots for debugger step in.
-    if (stepping) %DebugPrepareStepInIfStepping(f);
-    var new_receiver = needs_wrapper ? $toObject(receiver) : receiver;
-    if (!%_CallFunction(new_receiver, TO_OBJECT_INLINE(element), i, this, f)) {
-      return false;
-    }
-  }
-  return true;
+  return $innerArrayEvery(f, receiver, this, length);
 }
+%FunctionSetLength(TypedArrayEvery, 1);
 
 // ES6 draft 08-24-14, section 22.2.3.12
-function TypedArrayForEach(f /* thisArg */) {  // length == 1
+function TypedArrayForEach(f, receiver /* thisArg */) {  // length == 1

[adamk, 2015/05/11 22:39:24]

Ditto, no need for these comments anymore.

   if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
-  if (!IS_SPEC_FUNCTION(f)) throw MakeTypeError(kCalledNonCallable, f);
 
   var length = %_TypedArrayGetLength(this);
-  var receiver;
-
-  if (%_ArgumentsLength() > 1) {
-    receiver = %_Arguments(1);
-  }
 
-  var needs_wrapper = false;
-  if (IS_NULL(receiver)) {
-    if (%IsSloppyModeFunction(mapfn)) receiver = UNDEFINED;
-  } else if (!IS_UNDEFINED(receiver)) {
-    needs_wrapper = SHOULD_CREATE_WRAPPER(f, receiver);
-  }
-
-  var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
-  for (var i = 0; i < length; i++) {
-    var element = this[i];
-    // Prepare break slots for debugger step in.
-    if (stepping) %DebugPrepareStepInIfStepping(f);
-    var new_receiver = needs_wrapper ? $toObject(receiver) : receiver;
-    %_CallFunction(new_receiver, TO_OBJECT_INLINE(element), i, this, f);
-  }
+  $innerArrayForEach(f, receiver, this, length);
 }
+%FunctionSetLength(TypedArrayForEach, 1);
 
 // ES6 draft 08-24-14, section 22.2.2.2
 function TypedArrayOf() {  // length == 0