Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1133493007: Use mojo::StrongBinding in PlatformVerificationImpl. (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkrahn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mojo::StrongBinding in PlatformVerificationImpl. mojo::InterfaceImpl is being deprecated. See bug for details. BUG=489756, 479836 Committed: https://crrev.com/4f119d8b6834ceb1905c2798224973a94c5efd45 Cr-Commit-Position: refs/heads/master@{#330607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_impl.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_impl.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
PTAL to make sure I am using it correctly. Then I'll update other uses of ...
5 years, 7 months ago (2015-05-19 19:37:38 UTC) #2
jam
lgtm, thanks
5 years, 7 months ago (2015-05-19 20:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133493007/1
5 years, 7 months ago (2015-05-19 20:35:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 21:14:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:15:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f119d8b6834ceb1905c2798224973a94c5efd45
Cr-Commit-Position: refs/heads/master@{#330607}

Powered by Google App Engine
This is Rietveld 408576698