Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1133483006: IndexedDB: Disabling manifest (log) reuse on Chrome OS. (Closed)

Created:
5 years, 7 months ago by cmumford
Modified:
5 years, 7 months ago
Reviewers:
jsbell, matthewyuan
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Disabling manifest (log) reuse on Chrome OS. leveldb manifest (log) reuse was enabled on Chrome OS to decrease the time to open leveldb databases. Unfortunately that resulted in a corruption rate that was unacceptably high. Disabling this feature until the cause is identified and fixed. NOTRY=true NOPRESUBMIT=true BUG=483490, 460568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cmumford
jsbell for code review, matthewyuan for permission to press CQ to land in M42 branch ...
5 years, 7 months ago (2015-05-07 16:13:25 UTC) #2
jsbell
lgtm
5 years, 7 months ago (2015-05-07 16:14:08 UTC) #3
cmumford
On 2015/05/07 16:14:08, jsbell wrote: > lgtm Verbal approval from matthewyuan, so hitting CQ.
5 years, 7 months ago (2015-05-07 16:23:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133483006/1
5 years, 7 months ago (2015-05-07 16:24:23 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 7 months ago (2015-05-07 16:24:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133483006/1
5 years, 7 months ago (2015-05-07 16:27:18 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 16:29:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698