Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/history/core/browser/history_backend_notifier.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_backend_notifier.h
diff --git a/components/history/core/browser/history_backend_notifier.h b/components/history/core/browser/history_backend_notifier.h
index a4253e23499a4cccc8af58200537ba99933993be..0c0cfd835f0a42fcbfb06edb398bddd812064bf7 100644
--- a/components/history/core/browser/history_backend_notifier.h
+++ b/components/history/core/browser/history_backend_notifier.h
@@ -21,8 +21,13 @@ class HistoryBackendNotifier {
HistoryBackendNotifier() {}
virtual ~HistoryBackendNotifier() {}
- // Sends notification that favicon for |urls| have changed.
- virtual void NotifyFaviconChanged(const std::set<GURL>& urls) = 0;
+ // Sends notification that the favicons for the given page URLs (e.g.
+ // http://www.google.com) and the given icon URL (e.g.
+ // http://www.google.com/favicon.ico) have changed. It is valid to call
+ // NotifyFaviconsChanged() with non-empty |page_urls| and an empty |icon_url|
+ // and vice versa.
+ virtual void NotifyFaviconsChanged(const std::set<GURL>& page_urls,
+ const GURL& icon_url) = 0;
// Sends notification that |transition| to |row| occurred at |visit_time|
// following |redirects| (empty if there is no redirects).
« no previous file with comments | « components/history/core/browser/history_backend.cc ('k') | components/history/core/browser/history_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698