Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/sync/sessions/sessions_sync_manager.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/sessions_sync_manager.cc
diff --git a/chrome/browser/sync/sessions/sessions_sync_manager.cc b/chrome/browser/sync/sessions/sessions_sync_manager.cc
index d9428b1035a442eade6f583e96ea6bb8a8707195..da2e7a957eb1357ab9ad64eddf4a3dea28dd43a0 100644
--- a/chrome/browser/sync/sessions/sessions_sync_manager.cc
+++ b/chrome/browser/sync/sessions/sessions_sync_manager.cc
@@ -396,17 +396,17 @@ void SessionsSyncManager::OnLocalTabModified(SyncedTabDelegate* modified_tab) {
sync_processor_->ProcessSyncChanges(FROM_HERE, changes);
}
-void SessionsSyncManager::OnFaviconPageUrlsUpdated(
- const std::set<GURL>& updated_favicon_page_urls) {
+void SessionsSyncManager::OnFaviconsChanged(
+ const std::set<GURL>& page_urls,
+ const GURL& /* icon_url */) {
// TODO(zea): consider a separate container for tabs with outstanding favicon
// loads so we don't have to iterate through all tabs comparing urls.
- for (std::set<GURL>::const_iterator i = updated_favicon_page_urls.begin();
- i != updated_favicon_page_urls.end(); ++i) {
+ for (const GURL& page_url : page_urls) {
for (TabLinksMap::iterator tab_iter = local_tab_map_.begin();
tab_iter != local_tab_map_.end();
++tab_iter) {
- if (tab_iter->second->url() == *i)
- favicon_cache_.OnPageFaviconUpdated(*i);
+ if (tab_iter->second->url() == page_url)
+ favicon_cache_.OnPageFaviconUpdated(page_url);
}
}
}
« no previous file with comments | « chrome/browser/sync/sessions/sessions_sync_manager.h ('k') | chrome/browser/sync/test/integration/sessions_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698