Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index 50760c804766b570f7dd781a3955b118f4056f0e..6651445ae4234dee09c392683fa812f9bfc7e5e5 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -296,15 +296,20 @@ class BookmarkModel : public KeyedService {
void SetNodeSyncTransactionVersion(const BookmarkNode* node,
int64 sync_transaction_version);
- // Notify BookmarkModel that the favicons for |urls| have changed and have to
- // be refetched. This notification is sent by BookmarkClient.
- void OnFaviconChanged(const std::set<GURL>& urls);
+ // Notify BookmarkModel that the favicons for the given page URLs (e.g.
+ // http://www.google.com) and the given icon URL (e.g.
+ // http://www.google.com/favicon.ico) have changed. It is valid to call
+ // OnFaviconsChanged() with non-empty |page_urls| and an empty |icon_url| and
+ // vice versa.
+ void OnFaviconsChanged(const std::set<GURL>& page_urls,
+ const GURL& icon_url);
// Returns the client used by this BookmarkModel.
BookmarkClient* client() const { return client_; }
private:
friend class BookmarkCodecTest;
+ friend class BookmarkModelFaviconTest;
friend class BookmarkStorage;
friend class ScopedGroupBookmarkActions;
friend class TestBookmarkClient;

Powered by Google App Engine
This is Rietveld 408576698