Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index e222790c4dc1a74035bc837566ef089f1e770ef0..ea0460ad80c2ac56b95e1aa7ae55214487680e67 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -166,6 +166,10 @@ class BookmarkModel : public KeyedService {
// Returns the set of nodes with the |url|.
void GetNodesByURL(const GURL& url, std::vector<const BookmarkNode*>* nodes);
+ // Returns the set of nodes which use the favicon at |icon_url|.
+ void GetNodesByIconURL(const GURL& icon_url,
+ std::vector<const BookmarkNode*>* nodes);
+
// Returns the most recently added user node for the |url|; urls from any
// nodes that are not editable by the user are never returned by this call.
// Returns NULL if |url| is not bookmarked.
@@ -296,9 +300,12 @@ class BookmarkModel : public KeyedService {
void SetNodeSyncTransactionVersion(const BookmarkNode* node,
int64 sync_transaction_version);
- // Notify BookmarkModel that the favicons for |urls| have changed and have to
+ // Notify BookmarkModel that the favicons for the given page URLs
+ // (e.g. http://www.google.com) and the given icon URLs (e.g.
+ // http://www.google.com/favicon.ico) have changed and have to
// be refetched. This notification is sent by BookmarkClient.
- void OnFaviconChanged(const std::set<GURL>& urls);
+ void OnFaviconsChanged(const std::vector<GURL>& page_urls,
+ const std::vector<GURL>& icon_urls);
// Returns the client used by this BookmarkModel.
BookmarkClient* client() const { return client_; }

Powered by Google App Engine
This is Rietveld 408576698