chrome/browser/sync/sessions/notification_service_sessions_router.cc - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/notification_service_sessions_router.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sessions/notification_service_sessions_router.h ('k') | chrome/browser/sync/sessions/sessions_sync_manager.h » ('j') | chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sessions/notification_service_sessions_router.cc

diff --git a/chrome/browser/sync/sessions/notification_service_sessions_router.cc b/chrome/browser/sync/sessions/notification_service_sessions_router.cc

index fd27c12d5f8003ae420e5272bdcdec30cdf0ce3f..fa264b30c625a8ac2e7094c5186e0e03b9675b7c 100644

--- a/chrome/browser/sync/sessions/notification_service_sessions_router.cc

+++ b/chrome/browser/sync/sessions/notification_service_sessions_router.cc

@@ -62,7 +62,7 @@ NotificationServiceSessionsRouter::NotificationServiceSessionsRouter(

ServiceAccessType::EXPLICIT_ACCESS);

if (history_service) {

favicon_changed_subscription_ = history_service->AddFaviconChangedCallback(

- base::Bind(&NotificationServiceSessionsRouter::OnFaviconChanged,

+ base::Bind(&NotificationServiceSessionsRouter::OnFaviconsChanged,

base::Unretained(this)));

}

#if defined(ENABLE_SUPERVISED_USERS)

@@ -155,10 +155,11 @@ void NotificationServiceSessionsRouter::OnNavigationBlocked(

handler_->OnLocalTabModified(tab);

}

-void NotificationServiceSessionsRouter::OnFaviconChanged(

- const std::set<GURL>& changed_favicons) {

+void NotificationServiceSessionsRouter::OnFaviconsChanged(

+ const std::vector<GURL>& page_urls,

+ const std::vector<GURL>& icon_urls) {

if (handler_)

- handler_->OnFaviconPageUrlsUpdated(changed_favicons);

+ handler_->OnFaviconsChanged(page_urls, icon_urls);

}

void NotificationServiceSessionsRouter::StartRoutingTo(