chrome/browser/bookmarks/chrome_bookmark_client.h - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/bookmarks/chrome_bookmark_client.cc » ('j') | chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/chrome_bookmark_client.h

diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.h b/chrome/browser/bookmarks/chrome_bookmark_client.h

index e7ae884d4a7fe6974b514caaf7a4e3a331cffa0a..53b4ba68872110da5c476b465199291e3a57d1f2 100644

--- a/chrome/browser/bookmarks/chrome_bookmark_client.h

+++ b/chrome/browser/bookmarks/chrome_bookmark_client.h

@@ -105,7 +105,8 @@ class ChromeBookmarkClient : public bookmarks::BookmarkClient,

// is initialized from HistoryServiceFactory.

history::HistoryService* history_service_;

- scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>

+ scoped_ptr<base::CallbackList<void(const std::vector<GURL>&,

+ const std::vector<GURL>&)>::Subscription>

favicon_changed_subscription_;

// Pointer to the BookmarkModel. Will be non-NULL from the call to Init to

« no previous file with comments | « no previous file | chrome/browser/bookmarks/chrome_bookmark_client.cc » ('j') | chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc » ('J')