Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index aa84279b325bf891777812ac4a3d3f393a4af57e..c596de91f7f509a7fca84a11f2704fc3e2d71212 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2588,13 +2588,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Bookmarks.LaunchDepth">
<owner>yfriedman@chromium.org</owner>
<summary>
- Logs the depth of the bookmark in the bookmark tree hiearchy every time a
+ Logs the depth of the bookmark in the bookmark tree hierarchy every time a
bookmark is launched. Depth indicates how many levels below a permanent
bookmark folder the bookmark was found in (e.g. a bookmark immediately in
the bookmark bar has depth 1).
</summary>
</histogram>
+<histogram name="Bookmarks.OnFaviconsChangedMultipleIconURLs" enum="BooleanHit">
+ <owner>pkotwicz@chromium.org</owner>
+ <summary>
+ Logs how frequently BookmarkModel::OnFaviconsChanged() is called with
+ non-empty |icon_urls| to determine whether BookmarkNodes should be cached
+ based on their favicon URLs (e.g. http://www.google.com/favicon.ico) in
+ addition to their page URLs (e.g. http://www.google.com). OnFaviconChanged()
+ is expected to be called less than 10 times per user per day with non-empty
+ |icon_urls|.
+ </summary>
+</histogram>
+
<histogram name="BrowserRenderProcessHost.ChildCrashes" enum="RendererType">
<owner>wfh@chromium.org</owner>
<summary>Count of renderer process crashes grouped by type.</summary>

Powered by Google App Engine
This is Rietveld 408576698