Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index 50760c804766b570f7dd781a3955b118f4056f0e..b648d03b75a0294d4adc304dc39b82ed1954d8d7 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -298,7 +298,8 @@ class BookmarkModel : public KeyedService {
// Notify BookmarkModel that the favicons for |urls| have changed and have to
sky 2015/06/22 15:19:48 nit: update comment.
// be refetched. This notification is sent by BookmarkClient.
- void OnFaviconChanged(const std::set<GURL>& urls);
+ void OnFaviconsChanged(const std::set<GURL>& page_urls,
sky 2015/06/22 15:19:48 Please add test coverage of this function too.
+ const std::set<GURL>& icon_urls);
// Returns the client used by this BookmarkModel.
BookmarkClient* client() const { return client_; }

Powered by Google App Engine
This is Rietveld 408576698