chrome/browser/sync/test/integration/sessions_helper.cc - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/sessions/sessions_sync_manager.cc ('K') | « chrome/browser/sync/sessions/sessions_sync_manager.cc ('k') | chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sessions_helper.cc

diff --git a/chrome/browser/sync/test/integration/sessions_helper.cc b/chrome/browser/sync/test/integration/sessions_helper.cc

index e757f93b940bed7dcf08657cf5b4b5626f1452cd..c7d75aa8d6c1e3ca7337e5c65f19fab770a7ab0f 100644

--- a/chrome/browser/sync/test/integration/sessions_helper.cc

+++ b/chrome/browser/sync/test/integration/sessions_helper.cc

@@ -144,8 +144,8 @@ class TabEventHandler : public browser_sync::LocalSessionEventHandler {

base::Bind(&TabEventHandler::QuitLoop, weak_factory_.GetWeakPtr()));

}

- void OnFaviconPageUrlsUpdated(

- const std::set<GURL>& updated_page_urls) override {

+ void OnFaviconsChanged(const std::vector<GURL>& page_urls,

+ const std::vector<GURL>& icon_urls) override {

Roger McFarlane (Chromium) 2015/05/13 16:07:05 nit: comment out the param names, as they're not u

pkotwicz 2015/05/13 17:26:49 Done.

// Unwind to ensure SessionsSyncManager has processed the event.

base::MessageLoop::current()->PostTask(

FROM_HERE,