components/history/core/browser/expire_history_backend_unittest.cc - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/expire_history_backend_unittest.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_model.cc ('K') | « components/bookmarks/browser/bookmark_model.cc ('k') | components/history/core/browser/history_backend.h » ('j') | components/history/core/browser/history_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/expire_history_backend_unittest.cc

diff --git a/components/history/core/browser/expire_history_backend_unittest.cc b/components/history/core/browser/expire_history_backend_unittest.cc

index afea65471e368aa34688f5411dbf88a30bc7927f..6e2c0828b374c7285cc4690fc906312fb428217b 100644

--- a/components/history/core/browser/expire_history_backend_unittest.cc

+++ b/components/history/core/browser/expire_history_backend_unittest.cc

@@ -162,7 +162,8 @@ class ExpireHistoryTest : public testing::Test, public HistoryBackendNotifier {

}

// HistoryBackendNotifier:

- void NotifyFaviconChanged(const std::set<GURL>& urls) override {}

+ void NotifyFaviconsChanged(const std::vector<GURL>& page_urls,

+ const std::vector<GURL>& icon_urls) override {};

void NotifyURLVisited(ui::PageTransition transition,

const URLRow& row,

const RedirectList& redirects,