components/bookmarks/browser/bookmark_node.cc - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_node.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_model.h ('K') | « components/bookmarks/browser/bookmark_node.h ('k') | components/history/core/browser/expire_history_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_node.cc

diff --git a/components/bookmarks/browser/bookmark_node.cc b/components/bookmarks/browser/bookmark_node.cc

index f1a7945d31ecd052c9f88f6059b2be0239d2c86a..136da48a23dd51ae1c247e7799be272472b08b80 100644

--- a/components/bookmarks/browser/bookmark_node.cc

+++ b/components/bookmarks/browser/bookmark_node.cc

@@ -115,13 +115,6 @@ void BookmarkNode::Initialize(int64 id) {

sync_transaction_version_ = kInvalidSyncTransactionVersion;

}

-void BookmarkNode::InvalidateFavicon() {

- icon_url_ = GURL();

- favicon_ = gfx::Image();

- favicon_type_ = favicon_base::INVALID_ICON;

- favicon_state_ = INVALID_FAVICON;

// BookmarkPermanentNode -------------------------------------------------------

BookmarkPermanentNode::BookmarkPermanentNode(int64 id)