Update all bookmarks which use an icon URL when a favicon's bitmap is updated

chrome/browser/sync/sessions/sessions_sync_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_
 #define CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 45 matching lines @@
 // with session sync.  All local tab events flow to sync via this interface.
 // In that way it is analogous to sync changes flowing to the local model
 // via ProcessSyncChanges, just with a more granular breakdown.
 class LocalSessionEventHandler {
  public:
   // A local navigation event took place that affects the synced session
   // for this instance of Chrome.
   virtual void OnLocalTabModified(SyncedTabDelegate* modified_tab) = 0;
 
   // A local navigation occurred that triggered updates to favicon data for
-  // each URL in |updated_page_urls|.  This is routed through Sessions Sync so
-  // that we can filter (exclude) favicon updates for pages that aren't
-  // currently part of the set of local open tabs, and pass relevant updates
-  // on to FaviconCache for out-of-band favicon syncing.
-  virtual void OnFaviconPageUrlsUpdated(
-      const std::set<GURL>& updated_page_urls) = 0;
+  // each page URL in |page_urls| (e.g. http://www.google.com) and the icon URL
+  // |icon_url| (e.g. http://www.google.com/favicon.ico). This is routed through
+  // Sessions Sync so that we can filter (exclude) favicon updates for pages
+  // that aren't currently part of the set of local open tabs, and pass relevant
+  // updates on to FaviconCache for out-of-band favicon syncing.
+  virtual void OnFaviconsChanged(const std::set<GURL>& page_urls,
+                                 const GURL& icon_url) = 0;
 };
 
 // The LocalSessionEventRouter is responsible for hooking itself up to various
 // notification sources in the browser process and forwarding relevant
 // events to a handler as defined in the LocalSessionEventHandler contract.
 class LocalSessionEventRouter {
  public:
   virtual ~LocalSessionEventRouter();
   virtual void StartRoutingTo(LocalSessionEventHandler* handler) = 0;
   virtual void Stop() = 0;
@@ skipping 33 matching lines @@
       std::vector<const sessions::SessionWindow*>* windows) override;
   bool GetForeignTab(const std::string& tag,
                      const SessionID::id_type tab_id,
                      const sessions::SessionTab** tab) override;
   void DeleteForeignSession(const std::string& tag) override;
   bool GetLocalSession(
       const sync_driver::SyncedSession** local_session) override;
 
   // LocalSessionEventHandler implementation.
   void OnLocalTabModified(SyncedTabDelegate* modified_tab) override;
-  void OnFaviconPageUrlsUpdated(
-      const std::set<GURL>& updated_favicon_page_urls) override;
+  void OnFaviconsChanged(const std::set<GURL>& page_urls,
+                         const GURL& icon_url) override;
 
   // Returns the tag used to uniquely identify this machine's session in the
   // sync model.
   const std::string& current_machine_tag() const {
     DCHECK(!current_machine_tag_.empty());
     return current_machine_tag_;
   }
 
   // Return the virtual URL of the current tab, even if it's pending.
   static GURL GetCurrentVirtualURL(const SyncedTabDelegate& tab_delegate);
@@ skipping 244 matching lines @@
 
   scoped_ptr<LocalSessionEventRouter> local_event_router_;
   scoped_ptr<SyncedWindowDelegatesGetter> synced_window_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionsSyncManager);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_SESSIONS_SESSIONS_SYNC_MANAGER_H_