[Sync] Test Android passphrase creation UI

[Sync] Test Android passphrase creation UI

Tests various behaviors for the passphrase creation UI; specifically
when error messages are displayed and when submission succeeds.

BUG=480604
Committed: https://crrev.com/863e5ecccee406b68c32a6e90486215ea4dfaa0a
Cr-Commit-Position: refs/heads/master@{#330571}

[maxbogue, 2015-05-18 17:22:54]

maxbogue@chromium.org changed reviewers:
+ maniscalco@chromium.org

[maxbogue, 2015-05-18 17:22:55]

Hey Nick, could you review this test as well?

[maniscalco, 2015-05-18 18:57:29]

LGTM

[maxbogue, 2015-05-18 23:18:01]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org

[maxbogue, 2015-05-18 23:18:01]

+Nicolas for owner approval.

[maxbogue, 2015-05-18 23:41:17]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org
- zea@chromium.org

[maxbogue, 2015-05-18 23:41:18]

Looks like Nicolas is out until Wednesday; Tommy, could you stamp this?

[nyquist, 2015-05-19 07:09:39]

thanks! lgtm

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java
(right):

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:29:
private static final String TAG = "PassphraseCreationDialogFragment";
Nit: remove this line?

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/sync_she...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
(right):

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java:406:
private void clickButton(final Button button) {
Nit: I guess this technically could use
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestTouchUtils.java,
but it's fine to keep as is for me.

[maxbogue, 2015-05-19 18:11:54]

Thanks for the review guys.

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java
(right):

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:29:
private static final String TAG = "PassphraseCreationDialogFragment";
On 2015/05/19 07:09:38, nyquist wrote:
> Nit: remove this line?

Done.

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/sync_she...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
(right):

https://codereview.chromium.org/1133453010/diff/40001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java:406:
private void clickButton(final Button button) {
On 2015/05/19 07:09:38, nyquist wrote:
> Nit: I guess this technically could use
>
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestTouchUtils.java,
> but it's fine to keep as is for me.

Yeah, it's good to know about that class but since there are already several
other very similar methods here I think it's cleaner to understand if this one
lives here as well.

[maxbogue, 2015-05-19 18:12:20]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2015-05-19 18:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, maniscalco@chromium.org
Link to the patchset: https://codereview.chromium.org/1133453010/#ps60001
(title: "Remove TAG.")

[commit-bot: I haz the power, 2015-05-19 18:13:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133453010/60001

[commit-bot: I haz the power, 2015-05-19 18:37:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 18:38:23]

Patchset 4 (id:??) landed as
https://crrev.com/863e5ecccee406b68c32a6e90486215ea4dfaa0a
Cr-Commit-Position: refs/heads/master@{#330571}