Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1133443003: SkPDF: detect YUV-JPEG without relying on ImageGenerator (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 2 months ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-05-07 (Thursday) 10:19:26 EDT #

Patch Set 3 : 2015-05-07 (Thursday) 10:26:53 EDT #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -22 lines) Patch
M gyp/pdf.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A src/pdf/SkJpegInfo.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A src/pdf/SkJpegInfo.cpp View 1 2 3 1 chunk +121 lines, -0 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 1 2 3 5 chunks +13 lines, -22 lines 0 comments Download
M tests/PDFJpegEmbedTest.cpp View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133443003/1
5 years, 7 months ago (2015-05-07 02:57:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 03:03:37 UTC) #4
hal.canary
5 years, 7 months ago (2015-05-07 13:57:06 UTC) #6
msarett
lgtm. I like this code. I find it far more readable and understandable than what ...
5 years, 7 months ago (2015-05-07 14:22:23 UTC) #7
reed1
Perhaps we can make this a (private) utility function somewhere near our codecs, so we ...
5 years, 7 months ago (2015-05-07 14:42:23 UTC) #9
hal.canary
On 2015/05/07 14:22:23, msarett wrote: > lgtm. I like this code. I find it far ...
5 years, 7 months ago (2015-05-07 16:13:05 UTC) #10
reed1
We definitely want to learn how to link against libjpeg in chrome for Leon's extended ...
5 years, 7 months ago (2015-05-07 16:21:07 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133443003/60001
5 years, 7 months ago (2015-05-07 18:19:00 UTC) #14
hal.canary
unit tests and proper grayscale support added. Any objections to landing it as it stands, ...
5 years, 7 months ago (2015-05-07 18:21:00 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 18:36:37 UTC) #17
msarett
lgtm No objections to landing it as it stands and iterating.
5 years, 7 months ago (2015-05-07 18:42:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133443003/60001
5 years, 7 months ago (2015-05-07 18:46:15 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 18:47:05 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/96287f7af7ff6aaa48b8d28ec6b7b79836da2d7c

Powered by Google App Engine
This is Rietveld 408576698