Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 1133343006: Gyp: Sanity Part II (GM+Tests) (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -437 lines) Patch
M gyp/gmslides.gypi View 2 chunks +5 lines, -224 lines 0 comments Download
M gyp/tests.gypi View 2 chunks +18 lines, -202 lines 0 comments Download
M site/dev/testing/tests.md View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133343006/1
5 years, 7 months ago (2015-05-16 23:34:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-16 23:40:30 UTC) #4
hal.canary
PTAL
5 years, 7 months ago (2015-05-17 00:10:38 UTC) #6
mtklein
lgtm lgtm
5 years, 7 months ago (2015-05-17 13:47:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133343006/1
5 years, 7 months ago (2015-05-17 13:47:30 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-17 13:47:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2e0303f91bdada6dddb73105a82f17601265379d

Powered by Google App Engine
This is Rietveld 408576698