Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1133343003: Fix harmless HGraph verification failure after hoisting inlined bounds checks (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix harmless HGraph verification failure after hoisting inlined bounds checks BUG=chromium:487608 LOG=y R=yangguo@chromium.org Committed: https://crrev.com/f8175201da7cc6296b5028ef1f383a6e3b568dfa Cr-Commit-Position: refs/heads/master@{#28463}

Patch Set 1 #

Patch Set 2 : git add testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/hydrogen-bce.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-487608.js View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jakob Kummerow
PTAL.
5 years, 7 months ago (2015-05-15 16:14:03 UTC) #1
Yang
On 2015/05/15 16:14:03, Jakob wrote: > PTAL. lgtm
5 years, 7 months ago (2015-05-15 17:06:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133343003/20001
5 years, 7 months ago (2015-05-18 08:12:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 08:35:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133343003/20001
5 years, 7 months ago (2015-05-19 07:31:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 07:33:04 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 07:33:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8175201da7cc6296b5028ef1f383a6e3b568dfa
Cr-Commit-Position: refs/heads/master@{#28463}

Powered by Google App Engine
This is Rietveld 408576698