Issue 1133323003: Restore checked strlen conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133323003: Restore checked strlen conversions. (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Restore checked strlen conversions. The checked conversion can be re-enabled now that there is a public API free of private headers like this one. This reverts commit 6661fd4c26106cd530d187b36f29be7e5c98b70f. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/feb10c58777949ea3d300b7554204edde422d1f2

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	core/include/fxcrt/fx_system.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, the fruits of our public/ directory labors. Thanks.

5 years, 7 months ago (2015-05-12 21:38:35 UTC) #2

Tom Sepez

5 years, 7 months ago (2015-05-12 21:49:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
feb10c58777949ea3d300b7554204edde422d1f2 (presubmit successful).