Close mirroring window only when necessary

Close mirroring window only when necessary

always recreating was causing extra XRANR event on X11 system.

Delete WindowTreeHost asynchronously when the change can be made via input event.

BUG=484580, 486190
TEST=tested manually. no flicker.

Committed: https://crrev.com/16bc5f811ed1a927730e24d3fc73ac956face8fe
Cr-Commit-Position: refs/heads/master@{#329761}

[oshima, 2015-05-12 23:34:23]

Patchset #1 (id:1) has been deleted

[oshima, 2015-05-12 23:34:32]

Patchset #1 (id:20001) has been deleted

[oshima, 2015-05-12 23:34:38]

Patchset #1 (id:40001) has been deleted

[oshima, 2015-05-12 23:34:44]

Patchset #1 (id:60001) has been deleted

[oshima, 2015-05-12 23:34:49]

Patchset #1 (id:80001) has been deleted

[oshima, 2015-05-12 23:36:04]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[Jun Mukai, 2015-05-13 17:43:12]

a few nits

https://codereview.chromium.org/1133323002/diff/100001/ash/display/mirror_win...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/1133323002/diff/100001/ash/display/mirror_win...
ash/display/mirror_window_controller.cc:293: multi_display_mode_ =
DisplayManager::EXTENDED;
Can you remove this line?
Close() is called only from CloseIfNotNecessary() and d'tor, but
CloseIfNotNecessary() writes this field back to the expected, and after d'tor
this field is anyways inaccessible.

https://codereview.chromium.org/1133323002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1133323002/diff/100001/ash/shell.cc#newcode761
ash/shell.cc:761: // display_controller_->CloseMirroringDisplay();
Comment out doesn't look correct. CloseMirroringDisplayIfNecessary() isn't
sufficient?

[oshima, 2015-05-13 23:04:25]

https://codereview.chromium.org/1133323002/diff/100001/ash/display/mirror_win...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/1133323002/diff/100001/ash/display/mirror_win...
ash/display/mirror_window_controller.cc:293: multi_display_mode_ =
DisplayManager::EXTENDED;
On 2015/05/13 17:43:12, Jun Mukai wrote:
> Can you remove this line?
> Close() is called only from CloseIfNotNecessary() and d'tor, but
> CloseIfNotNecessary() writes this field back to the expected, and after d'tor
> this field is anyways inaccessible.

Done.

https://codereview.chromium.org/1133323002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1133323002/diff/100001/ash/shell.cc#newcode761
ash/shell.cc:761: // display_controller_->CloseMirroringDisplay();
On 2015/05/13 17:43:12, Jun Mukai wrote:
> Comment out doesn't look correct. CloseMirroringDisplayIfNecessary() isn't
> sufficient?

meant to be removed as this is done in shutdown correctly.

[Jun Mukai, 2015-05-13 23:22:17]

lgtm

[oshima, 2015-05-13 23:30:52]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-05-13 23:32:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133323002/120001

[commit-bot: I haz the power, 2015-05-14 00:25:52]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2015-05-14 00:26:46]

Patchset 2 (id:??) landed as
https://crrev.com/16bc5f811ed1a927730e24d3fc73ac956face8fe
Cr-Commit-Position: refs/heads/master@{#329761}