Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1133313003: Add the PE's IMAGE_LOAD_CONFIG_DIRECTORY for chrome.exe (Closed)

Created:
5 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
4 years, 9 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the PE's IMAGE_LOAD_CONFIG_DIRECTORY for chrome.exe This allows us to add global parameters that control the behavior of the default process heap. In this case we need to be less agressive about freeing memory. BUG=434397 Committed: https://crrev.com/9d7af519a13a1a5f169a039efc4d39c2737d71fe Cr-Commit-Position: refs/heads/master@{#329730}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/app/chrome_exe_load_config_win.cc View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cpu_(ooo_6.6-7.5)
Bruce, ptal. The idea here is to land and see what perf looks like, if ...
5 years, 7 months ago (2015-05-13 01:17:27 UTC) #2
brucedawson
A couple of comments, but lgtm. Whether we should ship it is another question, but ...
5 years, 7 months ago (2015-05-13 17:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133313003/40001
5 years, 7 months ago (2015-05-13 20:42:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 22:09:55 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9d7af519a13a1a5f169a039efc4d39c2737d71fe Cr-Commit-Position: refs/heads/master@{#329730}
5 years, 7 months ago (2015-05-13 22:11:43 UTC) #8
cpu_(ooo_6.6-7.5)
5 years, 7 months ago (2015-05-14 17:49:40 UTC) #9
Message was sent while issue was closed.
to note:
https://code.google.com/p/chromium/issues/detail?id=488156

Powered by Google App Engine
This is Rietveld 408576698